Opened 18 years ago

Closed 17 years ago

Last modified 2 years ago

#8206 closed patch

EGA LOOM / INDY3: Experimental bugfix

Reported by: eriktorbjorn Owned by: SF/khalek
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

I could use some input on this patch, so please don't apply until we've had some time to discuss it.

We already know that setting the CURSOR_STATE variable causes trouble in 256-colour Indy3 (see bug #636578).

Now it seems that setting it, and probably USERPUT as well, causes problems with EGA Loom: The spinning wheel always gives you the incorrect draft, "c c c c".

This patch is based on the theory that these two variables were added at the same time as subopcode 14 of o5_cursorCommand() changed. Can anyone confirm or deny this.

Ticket imported from: #729633. Ticket imported from: patches/311.

Attachments (1)

variable-experiment.diff (517 bytes ) - added by eriktorbjorn 18 years ago.
Patch against an April 29 CVS snapshot

Download all attachments as: .zip

Change History (7)

by eriktorbjorn, 18 years ago

Attachment: variable-experiment.diff added

Patch against an April 29 CVS snapshot

comment:1 by fingolfin, 17 years ago

Makes sense, and is what we suspected; what irritates me is that in bug #636578, aquadran said in the disassembly, they are being set ?!

Also, i wonder what's about Zak256 then... it's the only V3 game not covered by this patch, I think...

aquadran, any comments? If not, feel free to apply and/or reassign to me :-)

comment:2 by fingolfin, 17 years ago

Owner: set to aquadran

comment:3 by SF/khalek, 17 years ago

haven't looked into indy but I'm pretty sure this is the right thing to do for loom

comment:4 by SF/khalek, 17 years ago

I'm pretty sure this is the right thing to do (TM) applied

comment:5 by SF/khalek, 17 years ago

Owner: changed from aquadran to SF/khalek
Status: newclosed

comment:6 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Loom
Note: See TracTickets for help on using tickets.