Opened 17 years ago

Closed 17 years ago

Last modified 13 months ago

#8205 closed patch

INDY3: Better (but incomomplete) fix for intro costume bug

Reported by: eriktorbjorn Owned by: SF/khalek
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Indiana Jones 3


I've finally figured out why Indy gets the wrong
costume in the Indy3 intro. We already have a hack in
place to correct it, but this patch should be a lot
better, even if it's still slightly incomplete. It also
seems to fix some costume-related bugs at the end of
the game: The bouncing, severed head, and the second
trial, at least. Possibly others as well.

Consider the following script fragments:

script-58.dmp from Passport Demo:

[0022] (AC) Exprmode Var[37] = (9 - Var[118]);
[002D] (2C) InitCharset(1)
[0030] (2C) InitCursor(0)
[0033] (13)
[0042] (13)

script-118.dmp from Indy3:

[0022] (AC) Exprmode Var[37] = (9 - Var[66]);
[002D] (2C)
[0045] (13)

Since the Passport Demo works just fine, it becomes
pretty clear that the CursorCommand opcode is handled
incorrectly. This is what it'd look like after the patch:

[0022] (AC) Exprmode Var[37] = (9 - Var[66]);
[002D] (2C) UnkCursorCommand14(1,1)
[0031] (2C) InitCursor(0)
[0034] (13)
[0045] (13)

I don't know what CursorCommand, subopcode 14 should
really do. Something about the charset probably, but
I'm not sure what.

Ticket imported from: #729365. Ticket imported from: patches/310.

Attachments (1)

indy3-costume.diff (1.4 KB ) - added by eriktorbjorn 17 years ago.
Patch against an April 28 CVS snapshot

Download all attachments as: .zip

Change History (4)

by eriktorbjorn, 17 years ago

Attachment: indy3-costume.diff added

Patch against an April 28 CVS snapshot

comment:1 by SF/khalek, 17 years ago


comment:2 by SF/khalek, 17 years ago

Owner: set to SF/khalek
Status: newclosed

comment:3 by digitall, 13 months ago

Component: Engine: SCUMM
Game: Indiana Jones 3
Note: See TracTickets for help on using tickets.