Opened 16 years ago

Closed 16 years ago

Last modified 8 months ago

#8204 closed patch

EGA LOOM: Text masking

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

This patch adds text masking to the "Old256" charset
renderer. This makes a difference for EGA Loom, for
instance when examining the Great Loom for the first time.

At this point I'm starting to wonder if the charset
renderers couldn't be made to share more common code
between themselves than they do now, but that can wait.

There's still a FIXME comment in the function. Does
anyone know what that refers to?

Ticket imported from: #728754. Ticket imported from: patches/309.

Attachments (1)

loom-text-masking.diff (2.1 KB) - added by eriktorbjorn 16 years ago.
Patch against an April 27 CVS snapshot

Download all attachments as: .zip

Change History (4)

Changed 16 years ago by eriktorbjorn

Attachment: loom-text-masking.diff added

Patch against an April 27 CVS snapshot

comment:1 Changed 16 years ago by fingolfin

Owner: set to fingolfin
Status: newclosed

comment:2 Changed 16 years ago by fingolfin

Sharing common code is always a good thing :-)

No idea why we put that FIXME there, seems to be correct code... from my
POV it can be removed.

comment:3 Changed 8 months ago by digitall

Component: Engine: SCUMM
Game: Loom
Note: See TracTickets for help on using tickets.