Opened 21 years ago

Closed 21 years ago

Last modified 5 years ago

#8203 closed patch

DESCUMM3: Update for recent text-drawing changes

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Tools
Version: Keywords:
Cc: Game:


I have to apply this patch, or something like it, to get descumm3 to work properly with some of Loom's scripts.

Ticket imported from: #728484. Ticket imported from: patches/308.

Attachments (1)

descumm3.diff (562 bytes ) - added by eriktorbjorn 21 years ago.
Patch against an April 26 CVS snapshot

Download all attachments as: .zip

Change History (7)

by eriktorbjorn, 21 years ago

Attachment: descumm3.diff added

Patch against an April 26 CVS snapshot

comment:1 by fingolfin, 21 years ago

While we are at this, I think we should redo our descumm / dump-resource system.

The dumpResource function should but a fixed prefix to the file it creates, which contains a magic id followed by a header length (i.e. the same chunk format scumm uses :-), then scummvm version, the gameid, and possibly other information. This would allow us to merge the descumm tools: based on the file header, the right descumm version could be used; furthermore, it would be much nicer to make game specific adjustments (like the GF_OLD_BUNDLE etc. adjustments).

What do you think?

comment:2 by SF/khalek, 21 years ago

If you were to do this you would need another tool to attach headers to files that don't come from scummvm. For people who extract scripts with scummrev and various other tools/make their own etc.

The version of scummvm has no place in a header for dumped files in my opinion. Maybe you meant the scumm version?

comment:3 by fingolfin, 21 years ago

Status: newclosed

comment:4 by fingolfin, 21 years ago

Accepted with some mods.

Khalek, I meant a "version" for the header - in case we want to add more fields in the future. The reason for a magic id at the start is that if it's missing, we can still fall back to the old behaviour.

Still, most people will dump scripts with scummvm directly, I think, and for those (e.g. me :-) this would be very helpful... also would make developing descumm a bit easier. We could merge all the tools, too.

comment:5 by fingolfin, 21 years ago

Owner: set to fingolfin

comment:6 by digitall, 5 years ago

Component: Tools
Note: See TracTickets for help on using tickets.