Opened 18 years ago

Closed 18 years ago

Last modified 3 years ago

#8196 closed patch

SDL/GL: hotswap_gfx_mode (win32 and MacOS)

Reported by: SF/luke_br Owned by: Kirben
Priority: normal Component: Graphics
Version: Keywords:
Cc: Game:

Description

Untested hotswap_gfx_mode() mode for Win32 and MacOS. Also, there is a fix for the shaking in window mode with the game fitting the whole window (i hope it doesn't crash anymore on win32).

I have just tested it on Linux.

Ticket imported from: #721194. Ticket imported from: patches/301.

Attachments (2)

sdl_gl.cpp.patch (3.0 KB ) - added by SF/luke_br 18 years ago.
SDL/GL hotswap and black rectangle fix
fb2opengl.h.patch (14.7 KB ) - added by SF/luke_br 18 years ago.
More human readable fb2opengl.h

Download all attachments as: .zip

Change History (12)

by SF/luke_br, 18 years ago

Attachment: sdl_gl.cpp.patch added

SDL/GL hotswap and black rectangle fix

by SF/luke_br, 18 years ago

Attachment: fb2opengl.h.patch added

More human readable fb2opengl.h

comment:1 by fingolfin, 18 years ago

Owner: set to SF/ender

comment:2 by fingolfin, 18 years ago

Do we still want to support the GL backend, Endy, or ditch it?

comment:3 by Kirben, 18 years ago

Patch has been tested on win32 and added to ScummVM cvs. People are using the OpenGL backend of ScummVM and Andr is willing to keep it updated so I see no good reason to remove it.

comment:4 by Kirben, 18 years ago

Owner: changed from SF/ender to Kirben
Status: newclosed

comment:5 by SF/ender, 18 years ago

Kirben, it was good of you to apply the patch and all, but please refrain from closing things like this when they are assigned to someone and a question is pending :)

I am considering making some kind of change to the OpenGL backend, as many users try it - assuming it's "better" because it's OpenGL - and end up having problems.

Fingolfin, any thoughts on the possibility of making it a (non hot-swap) scaler instead? We should be able to tear down the OSystem SDL interface on scaler init and init with SDL_OGL instead, right?

Either way, we're going to really need some kind of configure script at least for *nix where OpenGL headers/libraries are not standard. Windows + Visual C, at least, should be fine in this regard.

comment:6 by SF/ender, 18 years ago

Status: closednew

comment:7 by SF/luke_br, 18 years ago

There is another way of rendering in SDL with OpenGL using the default blitting functions of SDL: passing SDL_OPENGLBLIT to setVideoMode. But i don't know if it would render a 320x240 screen (since some video cards only render 256x256 textures). And some effects might be lost (e.g. stretching, zoom, ...)

What problems are people finding with the SDL/GL version? I don't see any on the bug tracking system. I see that there is a request for a resizable window in SDL/GL and I am working on that.

comment:8 by Kirben, 18 years ago

Can this be closed now ?

comment:9 by Kirben, 18 years ago

Status: newclosed

comment:10 by digitall, 3 years ago

Component: Graphics
Note: See TracTickets for help on using tickets.