Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8193 closed patch

Fix for bug #695654 ("MI2: Wrong palette during diving")

Reported by: eriktorbjorn Owned by:
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 2

Description

I already attached this to the bug report, but I guess I should post it here as well, for better visibility.

This patch aims to fix a palette problem with scrollEffect() in MI2.

Ticket imported from: #713946. Ticket imported from: patches/298.

Attachments (1)

mi2-diving-fix.diff (446 bytes ) - added by eriktorbjorn 18 years ago.
Patch against an April 1 CVS shapshot

Download all attachments as: .zip

Change History (10)

by eriktorbjorn, 18 years ago

Attachment: mi2-diving-fix.diff added

Patch against an April 1 CVS shapshot

comment:1 by fingolfin, 18 years ago

The other methods also call updatePalette(), namely dissolveEffect and transitionEffect (the last one even calls it repeatedly, which seems to be redundant). So I really wonder, should we maybe just call updatePaleete() once at the start of fadeIn/fadeOut?

comment:2 by eriktorbjorn, 18 years ago

Sounds good to me. It was rather late at night when I finally got to the problem area, so I didn't think that far myself.

comment:3 by fingolfin, 18 years ago

Owner: set to fingolfin
Status: newclosed

comment:4 by fingolfin, 18 years ago

I used a different fix than this, by doing as I suggested (i.e. putting hte calls to updatePalette directly into fadeOut / fadeIn).

comment:5 by eriktorbjorn, 18 years ago

Owner: fingolfin removed
Status: closednew

comment:6 by eriktorbjorn, 18 years ago

Sounds good to me. It was rather late at night when I finally got to the problem area, so I didn't think that far myself.

comment:7 by eriktorbjorn, 18 years ago

Oops, I think my browser must have decided to re-post the old status. Closing again.

comment:8 by eriktorbjorn, 18 years ago

Status: newclosed

comment:9 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Monkey Island 2
Note: See TracTickets for help on using tickets.