Opened 17 years ago

Closed 17 years ago

Last modified 13 months ago

#8169 closed patch

CMI: Possible fix for actor redraw after load

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 3

Description

This patch aims to fix the problem where actors aren't
redrawn after loading a saved game in CMI. (The problem
almost certainly affects V7 games as well.)

The problem is that in V7 and V8 games the
redrawBGAreas() function, which is called by
scummLoop() and o6_kernelSetFunctions(), may reset
_fullRedraw to false. I think removing that line is the
proper fix.

In the case of scummLoop() it should simply mean that
_fullRedraw won't be reset until after the game has had
a chance to process the actors, and I don't think
that's a bad thing. I'm less certain of its effects on
o6_kernelSetFunctions(), but at worst we could always
add a line there to set _fullRedraw to false
afterwards. Where and when is that particular opcode
used anyway?

Ticket imported from: #679354. Ticket imported from: patches/274.

Attachments (1)

cmi-actor-redraw.diff (1.1 KB ) - added by eriktorbjorn 17 years ago.
Patch against a February 2 CVS snapshot

Download all attachments as: .zip

Change History (4)

by eriktorbjorn, 17 years ago

Attachment: cmi-actor-redraw.diff added

Patch against a February 2 CVS snapshot

comment:1 by SF/ender, 17 years ago

Applied

comment:2 by SF/ender, 17 years ago

Owner: set to SF/ender
Status: newclosed

comment:3 by digitall, 13 months ago

Component: Engine: SCUMM
Game: Monkey Island 3
Note: See TracTickets for help on using tickets.