Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8144 closed patch

SAM: Final (?) noir mode fix

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max

Description

Currently, Sam & Max ends noir mode by reloading the palette. Unfortunately this also undoes any palette manipulation (darkening, etc.) that the game may have made. For instance, in Sam's and Max's office, if you turn on noir mode, turn off the light, and turn off noir mode, the room will no longer appear dark.

This isn't really a ScummVM bug, since the same behaviour can be seen with the original interpreter as well. But since our implementation of noir mode never touches ScummVM's palette, there's no need to reload the palette. We just have to mark all colours as dirty and let updatePalette() do the rest.

So that's what this patch does.

Ticket imported from: #651882. Ticket imported from: patches/249.

Attachments (1)

noir.diff (1.3 KB ) - added by eriktorbjorn 18 years ago.
Patch against a December 10 CVS snapshot

Download all attachments as: .zip

Change History (3)

by eriktorbjorn, 18 years ago

Attachment: noir.diff added

Patch against a December 10 CVS snapshot

comment:1 by fingolfin, 18 years ago

Owner: set to fingolfin
Status: newclosed

comment:2 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Sam and Max
Note: See TracTickets for help on using tickets.