Opened 21 years ago

Closed 21 years ago

Last modified 5 years ago

#8134 closed patch

SMUSH: Text rendering regression

Reported by: eriktorbjorn Owned by: aquadran
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game:


A few days ago the text rendering for the Full Throttle intro movies - and possibly others - broke slightly. I believe it was when drawStringWrapCentered() was added. This patch makes the following changes to it:

* Wrap the lines to fit according to the 'width' parameter instead of the frame (screen?) width, unless 'width' is greater than the frame width.

* Ensure that the resulting text is never positioned so that it'd stick outside the left or right side of the screen.

In particular, the string "...but you have business know-how and killer instincts that I respect" is centered around X position -97, so there's simply no way to get it to look reasonable without adjusting it afterwards.

I don't know whether or not this is consistent with the original behaviour, but at least it should behave sanely.

Ticket imported from: #641704. Ticket imported from: patches/239.

Attachments (1)

smush-frender.diff (1.7 KB ) - added by eriktorbjorn 21 years ago.
Patch against a November 20 CVS snapshot

Download all attachments as: .zip

Change History (3)

by eriktorbjorn, 21 years ago

Attachment: smush-frender.diff added

Patch against a November 20 CVS snapshot

comment:1 by aquadran, 21 years ago

Owner: set to aquadran
Status: newclosed

comment:2 by digitall, 5 years ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.