Opened 17 years ago

Closed 17 years ago

Last modified 12 months ago

#8097 closed patch

SAM: Film noir mode bugfix

Reported by: eriktorbjorn Owned by: SF/khalek
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max

Description

The code that handles the "film noir" mode in Sam & Max
has picked up a few bugs since it was first introduced.
For instance, if you activate it in the very first
room, Sam and Max are drawn in the wrong colour. I
think this is because I wrote the code to modify the
original palette, causing further colour manipulations
to go wrong.

With this patch, the original palette is left
unchanged, and the colours are converted when they're
uploaded to the backend. I've also changed to another
conversion algorithm. The result isn't that different,
but it does seem to give slightly better contrast.

Ticket imported from: #625603. Ticket imported from: patches/202.

Attachments (3)

noir-fix.diff (4.2 KB ) - added by eriktorbjorn 17 years ago.
Patch against an October 18 CVS snapshot
snapshot1.png (45.7 KB ) - added by eriktorbjorn 17 years ago.
Screenshot, unpatched version
snapshot2.png (46.8 KB ) - added by eriktorbjorn 17 years ago.
Screenshot, patched version

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 17 years ago

Attachment: noir-fix.diff added

Patch against an October 18 CVS snapshot

by eriktorbjorn, 17 years ago

Attachment: snapshot1.png added

Screenshot, unpatched version

by eriktorbjorn, 17 years ago

Attachment: snapshot2.png added

Screenshot, patched version

comment:1 by SF/khalek, 17 years ago

http://users.bigpond.net.au/tgray2/noir.jpg shows the
differences between the original, the first patch and this
one because I have nothing better to do :)

applied and closing

comment:2 by SF/khalek, 17 years ago

Owner: set to SF/khalek
Status: newclosed

comment:3 by digitall, 12 months ago

Component: Engine: SCUMM
Game: Sam and Max
Note: See TracTickets for help on using tickets.