Opened 17 years ago

Closed 17 years ago

Last modified 13 months ago

#8087 closed patch

drawBomp() masking

Reported by: eriktorbjorn Owned by:
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: The Dig

Description

This patch should keep the inventory in The Dig from
covering text messages. (This would only happen in
scenes where the characters are seen from a great
distance, e.g. inside the asteroid.) There are two
parts to the it: Both drawBomp() and
removeBlastObject() need to be made to honor the
charset mask.

Fixing drawBomp() is much easier than fixing
removeBlastObject(), but I hope I got it right. I've
tested it with:

* Sam & Max: The LucasArts logos at the beginning of
the intro.
* Sam & Max: The floating objects outside the Mystery
Vortex.
* Sam & Max: Highway surfing.
* The Dig: The inventory window.
* The Dig: The conversation icons.

If anyone knows any other games/scenes that uses bomps,
I'd be grateful if they could test with them, too,
because it feels like every case I've tested has
revealed at least one new problem. This is actually the
third or fourth revision of the patch...

One unexpected bonus is that since drawBomp() now
honors the topmost mask, the patch also fixes the
masking problems outside the Mystery Vortex. Even the
original interpreter didn't handle that one correctly!

As you can see, the patch also changes
updateDirtyRect() so that it once again uses 200
instead of _realHeight. I just can't see how the screen
height could have anything to do with the rightmost
strip, so it must have been a coincidence that they are
the same.

Ticket imported from: #621733. Ticket imported from: patches/192.

Attachments (1)

bompmasking.diff (3.1 KB ) - added by eriktorbjorn 17 years ago.
Patch against an October 10 CVS snapshot

Download all attachments as: .zip

Change History (4)

by eriktorbjorn, 17 years ago

Attachment: bompmasking.diff added

Patch against an October 10 CVS snapshot

comment:1 by SF/ender, 17 years ago

Looks good :)

Applied (I think someone went a little bit overboard with copy/paste when it
came to _realHeight) - great work, as usual :)

comment:2 by SF/ender, 17 years ago

Status: newclosed

comment:3 by digitall, 13 months ago

Component: Engine: SCUMM
Game: The Dig
Note: See TracTickets for help on using tickets.