Opened 19 years ago

Closed 19 years ago

Last modified 3 years ago

#8080 closed patch

Regression fix: Text masking

Reported by: eriktorbjorn Owned by:
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Full Throttle

Description

In a recent attempt to fix the Full Throttle text masking problems, we removed a line from drawString() that would set charset._ignoreCharsetMask to 1. This was needed to keep the verb strings, e.g. Full Throttle's dialogue options, from being overdrawn by actors.

It turns out that drawString() is also used to draw strings that shouldn't mask, e.g. the credit texts in Sam & Max's intro.

This patch makes it so that _ignoreCharsetMask is once again set to 1, but not for verb strings.

Ticket imported from: #618985. Ticket imported from: patches/185.

Attachments (2)

snm-intro-fix.diff (563 bytes ) - added by eriktorbjorn 19 years ago.
Patch against an October 4 CVS snapshot
verb-text-fix.diff (738 bytes ) - added by eriktorbjorn 19 years ago.
Patch against an October 4 CVS snapshot

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 19 years ago

Attachment: snm-intro-fix.diff added

Patch against an October 4 CVS snapshot

comment:1 by SF/ender, 19 years ago

Applied

comment:2 by SF/ender, 19 years ago

Status: newclosed

comment:3 by eriktorbjorn, 19 years ago

Actually, this is what the patch should have looked like. With the first one, there's still a regression in the FOA intro. The line "What does a nazy want with a phony statue" (or something like that) never times out.

Apparently FOA prints the first message, and then some verb text.

(Sorry, I don't have a patch against the patched tree.)

by eriktorbjorn, 19 years ago

Attachment: verb-text-fix.diff added

Patch against an October 4 CVS snapshot

comment:4 by digitall, 3 years ago

Component: Engine: SCUMM
Game: Full Throttle
Note: See TracTickets for help on using tickets.