Opened 19 years ago

Closed 19 years ago

Last modified 3 years ago

#8062 closed patch

SAM: Experimental object-layering fix

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Sam and Max

Description

I don't understand this patch. There! I've said it.

However, it's neat enough that I still think it's likely to be the correct fix for the object-layering bug in Sam & Max. For those who don't know, this is the bug that causes actors to be drawn over conversation icons, and which would cause them to be drawn over the inventory box if it wasn't for a hack in actor.cpp.

One place where this would happen is when talking to the fisherman at the World of Fish.

What it does is simply to change the part of drawObject() that used to set the dbDrawMaskOnBoth flag on class 22 objects for GF_AFTER_V7 games so that it will do the same thing also for Sam & Max. As I said, I don't really understand it. But it does work.

Well, almost. You'll still get layering problems outside the Mystery Vortex. But those objects are drawn with drawBomp(), so it's really a completely different bug that just happens to look the same. For all I know, it might even match the original behaviour.

Ticket imported from: #613597. Ticket imported from: patches/167.

Attachments (3)

layering.diff (1.4 KB ) - added by eriktorbjorn 19 years ago.
Patch against a September 23 CVS snapshot
samnmax.s11 (62.4 KB ) - added by eriktorbjorn 19 years ago.
Mystery Vortex savegame
samnmax.s14 (65.0 KB ) - added by eriktorbjorn 19 years ago.
World of Fish savegame

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 19 years ago

Attachment: layering.diff added

Patch against a September 23 CVS snapshot

by eriktorbjorn, 19 years ago

Attachment: samnmax.s11 added

Mystery Vortex savegame

by eriktorbjorn, 19 years ago

Attachment: samnmax.s14 added

World of Fish savegame

comment:1 by SF/ender, 19 years ago

Applied :)

comment:2 by SF/ender, 19 years ago

Owner: set to SF/ender
Status: newclosed

comment:3 by digitall, 3 years ago

Component: Engine: SCUMM
Game: Sam and Max
Note: See TracTickets for help on using tickets.