#8060 closed patch
MI2 NewGui title fix
| Reported by: | SF/cccp_99 | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Monkey Island 2 |
Description
This is basically the same problem as before with special characters(FF...) in the dialog title of Monkey2. Because of code separation NewGui no longer converts them to proper strings, so this patch makes the strings 'normal' right after they are retreived from the loaded resource file. Changes to str.cpp were taken back since they're no longer needed. Old Gui still works with the previous fix (not perfect, but since it won't be used much longer, it doesn't really matter) After the Old Gui is gone, the function resStrLen() in util.h and util.cpp can be removed.
CCCP
Ticket imported from: #612722. Ticket imported from: patches/165.
Attachments (1)
Change History (4)
by , 22 years ago
| Attachment: | scummvm.diff added |
|---|
comment:1 by , 22 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:2 by , 22 years ago
I somewhat modified it to correct a few issues. In particular, delete was called on constant strings under certain conditions, and you had an "if(num < 0)" where you really wanted "if (value < 0)", but otherwise it seems to be just fine. Thanks, in CVS now.
comment:3 by , 5 years ago
| Component: | → Engine: SCUMM |
|---|---|
| Game: | → Monkey Island 2 |
changed files: common/str.cpp and scumm/dialogs.cpp