Opened 17 years ago

Closed 17 years ago

Last modified 12 months ago

#8057 closed patch

Simon crash fix

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: AGOS
Keywords: Cc:
Game: Simon the Sorcerer 1

Description

I think this is the correct fix for the recently
introduced "Simon crashes on startup" bug.

Ticket imported from: #611450. Ticket imported from: patches/162.

Attachments (1)

simonfix.diff (489 bytes ) - added by eriktorbjorn 17 years ago.
Patch against a september 18 CVS snapshot

Download all attachments as: .zip

Change History (5)

by eriktorbjorn, 17 years ago

Attachment: simonfix.diff added

Patch against a september 18 CVS snapshot

comment:1 by fingolfin, 17 years ago

Gee, Torbjrn, you really could check in such "trivial" fixes yourself by
now. You have proven over and over that you make high quality fixes :-)
I can understand that you want peer review for modifications where you
are not too happy with your current solution, but stuff like this is OK to
submit right away, and even if there is an issue with it, we can still back
it out easily :-)
That said, I don't mind checking in your patches, so if you prefer it, no
problem with me :-) I am grateful for your contributions anyway.

comment:2 by fingolfin, 17 years ago

Owner: set to fingolfin
Status: newclosed

comment:3 by eriktorbjorn, 17 years ago

Well, I can't access CVS from home, and I can't compile
ScummVM at work, which means there will always be at least
be 12 hours between the snapshot I've worked with and
current CVS.

That's why I feel much more comfortable if whoever checks in
the patch is someone who can make sure ScummVM still
compiles ok.

But I guess you're right in this particular case. :-)

comment:4 by digitall, 12 months ago

Component: Engine: AGOS
Game: Simon the Sorcerer 1
Note: See TracTickets for help on using tickets.