Opened 18 years ago

Closed 18 years ago

Last modified 17 months ago

#8051 closed patch

Sam & Max "phantom" sound fix

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max

Description

I've taken a closer look at the "phantom" sounds in Sam & Max. It turns out that at least the "Loading Sounds" script will set _vars[9] = 2 before playing the sound, using unkMessage1(). Adding a check for this variable seems to kill the phantom sounds.

But there's obviously more to this than I've been able to figure out, because the script that plays the Conroy Bumpus song sets _vars[9] = 1 before playing a few sounds.

If I change the _vars[9] check to only play sounds when _vars[9] == 0, the animation during Conroy's song works (much too fast?), but I only get the MIDI version of the music. I don't know what to make of this, but my guess is that the MIDI version should only be used for timing. It shouldn't be heard.

Ticket imported from: #609791. Ticket imported from: patches/156.

Attachments (3)

samsoundhack.diff (885 bytes ) - added by eriktorbjorn 18 years ago.
Patch against a September 15 CVS snapshot
loadingsounds.txt (19.0 KB ) - added by eriktorbjorn 18 years ago.
Descummed "loading sounds" script
conroysong.txt (25.2 KB ) - added by eriktorbjorn 18 years ago.
Descummed "Conroy song" script

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 18 years ago

Attachment: samsoundhack.diff added

Patch against a September 15 CVS snapshot

by eriktorbjorn, 18 years ago

Attachment: loadingsounds.txt added

Descummed "loading sounds" script

by eriktorbjorn, 18 years ago

Attachment: conroysong.txt added

Descummed "Conroy song" script

comment:1 by SF/ender, 18 years ago

Owner: set to SF/ender
Status: newclosed

comment:2 by SF/ender, 18 years ago

Applied, thanks.

The problems with Conroys songs are mostly related to the dodgy iMUSE implementation. We should fix THAT before looking into the other _vars[9] settings effect.

comment:3 by digitall, 17 months ago

Component: Engine: SCUMM
Game: Sam and Max
Note: See TracTickets for help on using tickets.