Opened 17 years ago

Closed 17 years ago

Last modified 13 months ago

#8050 closed patch

Sound patch for GF_OLD256 games

Reported by: (none) Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Indiana Jones 3

Description

What about some nice SCUMMVM-Habby-Birthday
Indy3/MI1music ?

Patch enables sound in GF_OLD256 games (verified
with indy3 & monkeyvga on PC).

Well it's a first effort. It's done via little "SO/AD"
to "ADL " resource tweaking.

The SO resource consists of AD and WA and nested
SO resources. There are 2 different AD formats. A long
(> 0x98h bytes) and a short form. The long is
background music and is played by this patch.

Todo:
a) A set of default instruments for all MIDI channels is
used, so you can hear the melody, but it's far from
perfect. Instruments are in the first 0x98h bytes of the
AD resource. I'am still trying to find (with help of the
adplug sources) some solution.

b) No sound looping. Who can help ?

c) The short form of AD resource is used for short
sounds (doors, steps etc.) and doesn't work right now.
But there are the WA (for WAVE ?) resource, which
maybe can be played raw.

d) The proper LE/BE handling have to be checked for
other platforms than PC/Intel.

Mikesch

Ticket imported from: #609649. Ticket imported from: patches/155.

Attachments (1)

old256sound.diff (17.8 KB ) - added by (none) 17 years ago.
against 15.9.2002 cvs

Download all attachments as: .zip

Change History (10)

by (none), 17 years ago

Attachment: old256sound.diff added

against 15.9.2002 cvs

comment:1 by SF/mnepomuk, 17 years ago

Login not working. It was me ;-)

comment:2 by SF/andrej4000, 17 years ago

It works!!!

most time music is much too fast, but it doesn't seem to
break anything in other games.

comment:3 by fingolfin, 17 years ago

Nice work. But over hear, the music is quite silent, i.e. I have to
massively turn up my speakers to be able to hear anything. And the
instruments are indeed completly off :-)

comment:4 by Kirben, 17 years ago

Patch has been added to cvs

comment:5 by Kirben, 17 years ago

Status: newclosed

comment:6 by fingolfin, 17 years ago

I am not so happy with this. The patch has severe issues here:
* completly wrong instruments (if they are not completly off for you,
maybe this is an endian issue)
* super low volume, barely audible here unless I turn up my speakers

Also, I wonder about some things in the code, maybe some more
comments wouldn't have hurt.

I think it's counter productive to just immediatly check in any given
patch, rather let's try to first at least fix any obvious major flaws. That
said, I fully appreciate mnepomuk work here, good work.

Travis, please if there are not resolved issues, don't just commit the
patch, discuss it first with Ender or me; or if you want to add it anyway
and none of is available, add FIXME comments indicating the known
problems to the source, including a reference to a tracker item (i.e. this
patch item) where more details are to be found.

comment:7 by fingolfin, 17 years ago

Owner: set to Kirben

comment:8 by SF/mnepomuk, 17 years ago

I agree with fingolfin (but: patch doesn't hurt) and I am working
on instruments, volume and comments ;-)

comment:9 by digitall, 13 months ago

Component: Engine: SCUMM
Game: Indiana Jones 3
Note: See TracTickets for help on using tickets.