Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8045 closed patch

unkRoomFunc3 (bug #588501)

Reported by: SF/jamieson630 Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

The included patch file makes corrections to the partial patch supplied with bug report #588501. The patch was a partial implementation of unkRoomFunc3. After considerable trial and error, I discovered that the shadow palette had to be constructed using the room's default (CLUT) palette, rather than the current palette (which was darkened almost to black in one case study). This is true for both the palette that is scaled by the supplied factors, AND for the palette against which to compare the scaled color for a closest-match.

In addition, the start and end palette locations ARE significant in that they bound the area of the palette that can be used to search for closest-match colors. For example, FOA Room 48 (subway crashing into Atlantis entrance area) restricts the palette entries to be used for the headlight beam to be in the range of 160 - 191.

This patch has been tested with all four FOA rooms that have been identified as using this opcode (23, 48, 53 and 82). Everything looks good, although close pixel scrutiny revealed occassional and very subtle difference in the resulting palette entries used, compared to the output of the LEC executable.

Finally, I left the function name as is because I'm not sure what we want to call this operation. shadowManipulate?

Ticket imported from: #608543. Ticket imported from: patches/150.

Attachments (1)

gfx.cpp.unkroomfunc3.diff (4.3 KB ) - added by SF/jamieson630 18 years ago.
Patch against gfx.cpp September 9 snapshot

Download all attachments as: .zip

Change History (3)

by SF/jamieson630, 18 years ago

Attachment: gfx.cpp.unkroomfunc3.diff added

Patch against gfx.cpp September 9 snapshot

comment:1 by fingolfin, 18 years ago

Owner: set to fingolfin
Status: newclosed

comment:2 by digitall, 2 years ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.