Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8036 closed patch

MI2 music fix (see bug report #551028)

Reported by: eriktorbjorn Owned by: SF/chuzwuzza
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 2

Description

This patch attempts to fix the MI2 music bug pointed out in bug report #551028 ("MI2: mojo music not played correctly"). It does so by looking at a previously unhandled SysEx command which I believe should turn parts on or off. It's guesswork, of course, but it seems to be doing the right thing, and I haven't seen it break anything else so far.

(Neither DotT nor Sam&Max seem to use this feature at all, and I've only seen FOA use it to turn parts on that already were.)

Apart from the swamp, other places where you can hear the difference include the graveyard and the room with the three sleeping pirates. I'm not attaching any savegames since these places can all be found at the very beginning of the game.

Ticket imported from: #606318. Ticket imported from: patches/141.

Attachments (1)

mi2music.diff (734 bytes ) - added by eriktorbjorn 18 years ago.
Patch against a September 3 CVS snapshot

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 18 years ago

Attachment: mi2music.diff added

Patch against a September 3 CVS snapshot

comment:1 by SF/lethalwp, 18 years ago

Status: newclosed

comment:2 by fingolfin, 18 years ago

So does that mean we can close #551028 now?

comment:3 by eriktorbjorn, 18 years ago

I think so, yes.

comment:4 by fingolfin, 18 years ago

Owner: set to SF/chuzwuzza

comment:5 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Monkey Island 2
Note: See TracTickets for help on using tickets.