Opened 18 years ago

Closed 18 years ago

Last modified 17 months ago

#8035 closed patch

MI2 sfx hack (see bug report #602348)

Reported by: eriktorbjorn Owned by: SF/chuzwuzza
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 2

Description

As was pointed out in bug report #602348, the sound effects for Largo's screams aren't played because the script only plays them on type 5 soundcards, while ScummVM claims to have a type 3 soundcard.

The simplest fix would, have course, have been to change ScummVM's soundcard value but - and this really annoys me - there is at least one sound effect (the bartender spitting) that will *only* play on type 3 soundcards.

It would be a shame to lose any of the digitized sound effects, even when the original interpreter didn't play them, so this is an ugly hack to make the soundcard test true even for type 5.

Does any if there are any other situations like this?

Ticket imported from: #604384. Ticket imported from: patches/140.

Attachments (1)

largo.diff (897 bytes ) - added by eriktorbjorn 18 years ago.
Patch against a September 3 CVS snapshot

Download all attachments as: .zip

Change History (6)

by eriktorbjorn, 18 years ago

Attachment: largo.diff added

Patch against a September 3 CVS snapshot

comment:1 by SF/chuzwuzza, 18 years ago

Status: newclosed

comment:2 by fingolfin, 18 years ago

Owner: set to SF/chuzwuzza

comment:3 by fingolfin, 18 years ago

So can bug #602348 be closed now?

chuzwuzza, when you accept patches, don't just close them, also assign them to you and mark them as accepted. Also, if there are items depending on the patch (like that bug report), it would be good to check if the bugs can be closed as a consequence of the patch being applied). Thanks! And thanks to Erik for the patch, too :-)

comment:4 by SF/chuzwuzza, 18 years ago

Sorry about that, fingolfin. I'm new to all this =) and Ender just wanted someone to test and apply some of the patches. And yes, I guess that means bug #602348 can be closed

comment:5 by digitall, 17 months ago

Component: Engine: SCUMM
Game: Monkey Island 2
Note: See TracTickets for help on using tickets.