Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8025 closed patch

fade modes (feature request #596788)

Reported by: eriktorbjorn Owned by:
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Indiana Jones 4

Description

This is an attempt at implementing the missing fade modes mentioned in feature request #596788. I would appreciate if someone who has actually seen the original effects could take a look at it.

However, I think the result look quite reasonable for the cases mentioned in the feature request, except I completely forgot to check what the scenes with eel figurines look like.

I still don't know what unkScreenEffect5(1) is supposed to do, so that one is still a no-op.

If it is guaranteed that we don't manipulate larger images than 320x200 the offsets array should probably be changed from int to uint16 to save memory, but I didn't dare to make that assumption.

Ticket imported from: #599909. Ticket imported from: patches/130.

Attachments (1)

dissolve.diff (4.8 KB ) - added by eriktorbjorn 18 years ago.
Patch against an August 24 CVS snapshot of scummvm-new

Download all attachments as: .zip

Change History (5)

by eriktorbjorn, 18 years ago

Attachment: dissolve.diff added

Patch against an August 24 CVS snapshot of scummvm-new

comment:1 by aquadran, 18 years ago

Status: newclosed

comment:2 by aquadran, 18 years ago

patch applied

comment:3 by eriktorbjorn, 18 years ago

I know the patch has already been applied, but...

I was able to check with the Amiga version of Loom, and found that to emulate the fade-ins of that one I should have used dissolveEffect(8, 4), not dissolveEffect(8, 8).

I still don't know what the fade-ins/outs in Loom CD should look like. Even with Mo'Slo they're too damn fast to make out on this computer.

The eel figurine scenes in FOA work as I intended, though. One of them use unkScreenEffect(0), and the other one doesn't seem to use any screen effect at all.

comment:4 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Indiana Jones 4
Note: See TracTickets for help on using tickets.