Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#7990 closed patch

Sam & Max "film noir" mode

Reported by: eriktorbjorn Owned by:
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max

Description

This is an attempt to implement the Sam & Max "film noir" (i.e. black and white) mode. Use the "B" key from within the game to toggle this mode. However, since I haven't actually seen what this game looks like with the original interpreter, I don't know how faithful it is.

I'm also not very familiar with the ScummVM internals, so I may have done something stupid without noticing. Hopefully I didn't break anything important.

(Looking at the patch again, I just realized that in scummvm.cpp I meant to call desaturatePalette() after the declaration of all the local variables, not in the middle of them. Since it doesn't really matter, except stylistically, and since I'm at a computer where I couldn't test a modified patch, I'll submit it in its current shape anyway.)

Ticket imported from: #586659. Ticket imported from: patches/95.

Attachments (2)

noir.diff (2.6 KB ) - added by eriktorbjorn 18 years ago.
Sam & Max "film noir" patch
noir2.diff (2.3 KB ) - added by eriktorbjorn 18 years ago.
Refined patch

Download all attachments as: .zip

Change History (10)

by eriktorbjorn, 18 years ago

Attachment: noir.diff added

Sam & Max "film noir" patch

comment:1 by eriktorbjorn, 18 years ago

I forgot to mention. The patch is made against a July 23 CVS snapshot.

comment:2 by SF/khalek, 18 years ago

looks good, I dug up a screenshot of the original interpreter http://www.mobygames.com/game/shots/gameShotId,14541/gameId,745/ and made up a quick comparison image of scummvm with this patch applied which can be found here http://users.bigpond.net.au/tgray2/noir.jpg the only difference I can see is that the original seems to be a tad darker.

anyone see any reason why this shouldn't be merged into cvs?

comment:3 by SF/khalek, 18 years ago

eriktorbjorn: are you happy to see this merged into cvs in the knowledge that scummvm may change to another open source license in the future?

comment:4 by eriktorbjorn, 18 years ago

Oh, absolutely. As long as I'm still free to use it, any license changes are ok as far as I'm concerned.

comment:5 by SF/khalek, 18 years ago

Status: newclosed

comment:6 by SF/khalek, 18 years ago

ok merged now closing, thanks :)

by eriktorbjorn, 18 years ago

Attachment: noir2.diff added

Refined patch

comment:7 by eriktorbjorn, 18 years ago

(I don't know if I should create a new patch, or if comments to closed ones are still being monitored. Let's try it this way first.)

This is a slight refinement to the original patch, and since it's made against a July 26 snapshot the first patch has already been applied.

What I realized was that it wasn't really necessary to call desaturatePalette() from o6_miscOps(). All I have to do is to mark the palette as dirty and let updatePalette() do the rest.

However, if we really want to preserve all the bugs of the original we should call desaturatePalette() from o6_miscOps() only, and not from updatePalette(). The comments added by the patch elaborates on this subject, but I don't see any compelling reason for such bug-compatibility.

comment:8 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Sam and Max
Note: See TracTickets for help on using tickets.