#7988 closed patch
Does this fix bug #580972?
| Reported by: | eriktorbjorn | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: AGOS |
| Version: | Keywords: | ||
| Cc: | Game: | Simon the Sorcerer 1 |
Description
This patch fixes the overlapping text bug encountered in the Simon the Sorcerer demo. The change is quite simple, really: There are two occasions where SimonState::talk_with_text() inserts a space into the output buffer, where I think it should insert a newline instead.
The only other change I've made is to remove a few checks for if threeval_b < 2, since that's done once and for all at the end of the function anyway.
I would be very grateful if someone who's familiar with the full version of the game could check if this also fixes bug #580972, and that it doesn't break anything else.
The patch is made against a CVS snapshot from July 23.
Ticket imported from: #585725. Ticket imported from: patches/93.
Attachments (1)
Change History (4)
by , 22 years ago
| Attachment: | simon.diff added |
|---|
comment:1 by , 22 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:2 by , 22 years ago
Sadly I don't have Simon, so I can't test this. However, your patch looks completly OK. Hence I will check it in anyway, this way, the users that do have simon can test it. In the worst case, I could easily back it out again.
comment:3 by , 6 years ago
| Component: | → Engine: AGOS |
|---|---|
| Game: | → Simon the Sorcerer 1 |
Experimental patch