Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#7988 closed patch

Does this fix bug #580972?

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: AGOS
Keywords: Cc:
Game: Simon the Sorcerer 1

Description

This patch fixes the overlapping text bug encountered in the Simon the Sorcerer demo. The change is quite simple, really: There are two occasions where SimonState::talk_with_text() inserts a space into the output buffer, where I think it should insert a newline instead.

The only other change I've made is to remove a few checks for if threeval_b < 2, since that's done once and for all at the end of the function anyway.

I would be very grateful if someone who's familiar with the full version of the game could check if this also fixes bug #580972, and that it doesn't break anything else.

The patch is made against a CVS snapshot from July 23.

Ticket imported from: #585725. Ticket imported from: patches/93.

Attachments (1)

simon.diff (1.2 KB ) - added by eriktorbjorn 18 years ago.
Experimental patch

Download all attachments as: .zip

Change History (4)

by eriktorbjorn, 18 years ago

Attachment: simon.diff added

Experimental patch

comment:1 by fingolfin, 18 years ago

Owner: set to fingolfin
Status: newclosed

comment:2 by fingolfin, 18 years ago

Sadly I don't have Simon, so I can't test this. However, your patch looks completly OK. Hence I will check it in anyway, this way, the users that do have simon can test it. In the worst case, I could easily back it out again.

comment:3 by digitall, 2 years ago

Component: Engine: AGOS
Game: Simon the Sorcerer 1
Note: See TracTickets for help on using tickets.