Opened 19 years ago

Closed 19 years ago

Last modified 2 years ago

#7983 closed patch

Channel_MP3_CDMUSIC volume

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Audio
Version: Keywords:
Cc: Game:

Description

This patch, which was made against a CVS snapshot from July 18, should make Channel_MP3_CDMUSIC take its volume setting from music_volume instead of sfx_volume. I think this makes sense, even if MI1 does use it for some ambient sound effects.

Ticket imported from: #583812. Ticket imported from: patches/88.

Attachments (1)

mp3volume.diff (2.7 KB ) - added by eriktorbjorn 19 years ago.
Diff against a CVS snapshot from July 18

Download all attachments as: .zip

Change History (8)

by eriktorbjorn, 19 years ago

Attachment: mp3volume.diff added

Diff against a CVS snapshot from July 18

comment:1 by SF/ender, 19 years ago

Owner: set to SF/ender

comment:2 by SF/ender, 19 years ago

Applied, thanks :)

Do you agree to have this code relicensed in the future? We may be changing from the GPL to another (still open-source) license soon'ish.

comment:3 by eriktorbjorn, 19 years ago

Of course! It's such a trivial change, but even if it wasn't it would still be extremely ungrateful of me to refuse. I mean, if it wasn't for ScummVM I might never have had the chance to play these LucasArts games at all!

(Of course, thanks should also go to the LucasArts store for still selling the games, and to their legal department for drawing my attention to ScummVM in the first place. ;-)

comment:4 by fingolfin, 19 years ago

Can this be closed then?

comment:5 by SF/ender, 19 years ago

Status: newclosed

comment:6 by SF/ender, 19 years ago

Sure can :)

Closed. Thanks.

comment:7 by digitall, 2 years ago

Component: Audio
Note: See TracTickets for help on using tickets.