Opened 9 years ago

Closed 7 years ago

Last modified 11 months ago

#7764 closed enhancement (fixed)

IPHONE: Cursor Palettes Don't Work

Reported by: SF/mthreepwood Owned by: lordhoto
Priority: normal Component: Port: iOS
Keywords: Cc:
Game:

Description

The iPhone backend does not implement setCursorPalette() leading to various cursor problems, including:

- The GUI's cursor is various colors
- The 7th Guest's cursors are hard to make out
- Mac HE games' cursors are the wrong colors

Ticket imported from: #2999152. Ticket imported from: feature-requests/580.

Change History (8)

comment:1 by lordhoto, 9 years ago

Actually I do not consider this a bug in the iPhone port really. The cursor palette is still optional code, i.e. if it is present, the according OSystem flag should be set. If it is not set, the client code should not rely on it. Simple as that.

Personally I would propose to move this to the feature request tracker and create bug entries for the client code you mention.

comment:2 by fingolfin, 9 years ago

Actually, this is not really a bug. Backends do not need to implement cursor palettes, at least this is currently so. And note that the PS2 backend also doesn't implement this.

We certainly could re-evaluate this and change the OSystem API to make this feature mandatory, but until the time being, this should not be considered as a bug, bug rather as a feature request.

comment:3 by SF/mthreepwood, 9 years ago

I agree that the missing feature part is a bug, the GUI cursor being strange colors *is* a bug. Shall I create another bug report for that?

comment:4 by fingolfin, 9 years ago

Sure. But is it a bug in the iPhone port, or in some other code (say, the GUI code) which maybe does not correctly honor the kFeatureCursorHasPalette feature flag?

comment:5 by SF/mthreepwood, 9 years ago

It's a GUI bug, I believe. kFeatureCursorHasPalette is checked within ThemeEngine::createCursor(), but doesn't do anything other than not apply the cursor defined in the theme. It defaults to the classic cursor with GuiManager::loadNewTheme() then but just uses whatever palette is set.

comment:6 by lordhoto, 7 years ago

Owner: changed from vinterstum to lordhoto
Resolution: fixed
Status: newclosed

comment:7 by lordhoto, 7 years ago

We support cursor palettes in the iPhone port for some time now. So I will close this. But still it would be nice to have bug reports for the client code, which does simply use cursor palettes without checking whether cursor palettes are actually supported. If someone wants to take a look at opening bug reports for these, please go ahead.

comment:8 by digitall, 11 months ago

Component: Port: iOS
Note: See TracTickets for help on using tickets.