Opened 10 years ago

Last modified 7 months ago

#7684 new enhancement

DS: Change options dialog to use popup widget for zoom level

Reported by: fingolfin Owned by: agent-q
Priority: normal Component: Port: NDS
Keywords: Cc:


Would be nice to have radio buttons in the GUI. They would have to be grouped, so that when one is selected, the others are deselected.

The DS ports would benefit from that; it currently fakes radio buttons in its options dialog by using checkboxes and lots of code which "manually" deselects the other checkboxes in the same group (the groups being hard coded, naturally...). See also dsoptions.cpp, e.g. DSOptionsDialog::handleCommand() in there.

Ticket imported from: #2594874. Ticket imported from: feature-requests/500.

Change History (11)

comment:1 Changed 10 years ago by jvprat

I can't see a clear advantadge of radio buttons over the popup widget. Both allow selection of 1 option from a predefined set, and the popup widget has the advantadge of requiring less screen space when not active (which I think would be a big plus for the DS' small resolution).

comment:2 Changed 10 years ago by fingolfin

Owner: set to agent-q

comment:3 Changed 10 years ago by fingolfin

You are probably right. Neil, what do you say?

comment:4 Changed 10 years ago by agent-q

Yeah, the code which fakes radio buttons is pretty dirty. If I remember correctly though, at the time many widgets didn't allow me to create them without defining their parameters in the theme definition. Or, at least, it looked that way. I didn'r understand all the theme stuff so I did it the way that seemed simple.

Radio buttons might be nice, or I could switch to a drop down list. I'm not bothered either way and obviously there's an advantage to keeping the number of widgets to a minimum.

comment:5 Changed 10 years ago by fingolfin

I think switching to a popup / dropdown menu would be best then. This would be less confusing to the use than the current "checkboxes that behave like radio buttons", and it would simplify your code, too.

comment:6 Changed 10 years ago by sev-

Status: newpending

comment:7 Changed 10 years ago by sev-

Thus, as I suppose, the arguments are valid, and we'd better stick to popup widgets?

comment:8 Changed 10 years ago by fingolfin

Instead of closing this, I am turning this into a request to switch the NDS port away frm abusing checkboxes, to using a popup :). Specifically, instead of having three checkboxes for 100%, 150% and 200%, there should be a single popup.

comment:9 Changed 10 years ago by fingolfin

Status: pendingnew
Summary: GUI: Add RadioButtonWidgetDS: Change options dialog to use popup widget for zoom level

comment:10 Changed 5 years ago by digitall

Component: Ports

comment:11 Changed 7 months ago by digitall

Component: PortsPort: NDS
Note: See TracTickets for help on using tickets.