Opened 14 years ago
Closed 2 years ago
#7684 closed feature request (outdated)
DS: Change options dialog to use popup widget for zoom level
| Reported by: | fingolfin | Owned by: | ccawley2011 |
|---|---|---|---|
| Priority: | normal | Component: | Port: NDS |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Would be nice to have radio buttons in the GUI. They would have to be grouped, so that when one is selected, the others are deselected.
The DS ports would benefit from that; it currently fakes radio buttons in its options dialog by using checkboxes and lots of code which "manually" deselects the other checkboxes in the same group (the groups being hard coded, naturally...). See also dsoptions.cpp, e.g. DSOptionsDialog::handleCommand() in there.
Ticket imported from: #2594874. Ticket imported from: feature-requests/500.
Change History (12)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
| Owner: | set to |
|---|
comment:4 by , 14 years ago
Yeah, the code which fakes radio buttons is pretty dirty. If I remember correctly though, at the time many widgets didn't allow me to create them without defining their parameters in the theme definition. Or, at least, it looked that way. I didn'r understand all the theme stuff so I did it the way that seemed simple.
Radio buttons might be nice, or I could switch to a drop down list. I'm not bothered either way and obviously there's an advantage to keeping the number of widgets to a minimum.
comment:5 by , 14 years ago
I think switching to a popup / dropdown menu would be best then. This would be less confusing to the use than the current "checkboxes that behave like radio buttons", and it would simplify your code, too.
comment:6 by , 14 years ago
| Status: | new → pending |
|---|
comment:7 by , 14 years ago
Thus, as I suppose, the arguments are valid, and we'd better stick to popup widgets?
comment:8 by , 14 years ago
Instead of closing this, I am turning this into a request to switch the NDS port away frm abusing checkboxes, to using a popup :). Specifically, instead of having three checkboxes for 100%, 150% and 200%, there should be a single popup.
comment:9 by , 14 years ago
| Status: | pending → new |
|---|---|
| Summary: | GUI: Add RadioButtonWidget → DS: Change options dialog to use popup widget for zoom level |
comment:10 by , 9 years ago
| Component: | → Ports |
|---|
comment:11 by , 5 years ago
| Component: | Ports → Port: NDS |
|---|
comment:12 by , 2 years ago
| Owner: | changed from to |
|---|---|
| Resolution: | → outdated |
| Status: | new → closed |
The DS options dialog was removed in the recent rewrite of the backend code.
I can't see a clear advantadge of radio buttons over the popup widget. Both allow selection of 1 option from a predefined set, and the popup widget has the advantadge of requiring less screen space when not active (which I think would be a big plus for the DS' small resolution).