Opened 16 years ago

Closed 16 years ago

Last modified 8 months ago

#763 closed defect (fixed)

o5_resourceRoutines: mistake?

Reported by: SF/hibernatus Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:


In Scumm_v5::o5_resourceRoutines, you do "_opcode
&= 0x3F" and later you use getVarOrDirectWord(0x40)
(case 20).

Ticket imported from: #734057. Ticket imported from: bugs/763.

Change History (5)

comment:1 Changed 16 years ago by SF/trinity78


only post patches in the patch-tracker. this is certainly not a
patch. either use the forum if this is a question or if you think
this is a bug use the bug tracker.
only post patches here. patches are usually diff-files which
contain source code. this source code either fixes a bug or
adds a new feature to the scummvm code base.


comment:2 Changed 16 years ago by fingolfin

Trinity78 is right. But still, well spotted ;-) I think I introduced this
stupid goof <sigh>.

I am very busy, dunno if I find the time to fix it (even though it's trivial,
but I mean busy as in: I shouldn't even write this).
Probably just have to copy opcode to another var, then use that for the
switch (IIRC we "& 0x3f" _opcode to switch on it, right?)

comment:3 Changed 16 years ago by fingolfin

Fixed in CVS.

comment:4 Changed 16 years ago by fingolfin

Owner: set to fingolfin
Resolution: fixed
Status: newclosed

comment:5 Changed 8 months ago by digitall

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.