Opened 12 years ago

Closed 12 years ago

Last modified 13 months ago

#7628 closed enhancement

GUI: Change mass detector to add all game (variants) it sees

Reported by: dreammaster Owned by: fingolfin
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

ScummVM 0.12.0svn (Mar 28 2008 23:34:29)
Features compiled in: Vorbis MP3 zLib MPEG2

When doing a Mass Add, the multiple variations of Lure of the Temptress English version aren't detected - only the EGA version, rather than both the EGA and VGA versions.

The issue is likely that support for detecting multiple game versions in the same folder was only recently added - Lure of the Temptress originally shipped with both EGA and VGA version files, so both versions needed to be detectable by ScummVM in the same folder.

The Mass Add functionality likely just needs to be updated to add all detected versions of a game in the given folder.

Ticket imported from: #1928546. Ticket imported from: feature-requests/444.

Change History (8)

comment:1 by fingolfin, 12 years ago

The current behavior is intentional, not a bug. The mass detector, if it detects multiple possible (!) games in a directory simply picks the first one, always. The motivation is that in general, we never supported multiple games in a single dir too well if at all; the usually reason for a detector to report multiple games in a dir was/is that it just can't decide which variant it is seeing there.

But I guess you are right, it is better to add all variants/games the detector(s) find and let the user decide which ones are valid, resp. which ones he wants to play.

comment:2 by fingolfin, 12 years ago

Component: Engine: Lure
Game: Lure of the Temptress
Summary: GUI: Multiple Lure versions in same folder not detectedGUI: Change mass detector to add all game (variants) it sees

comment:3 by sev-, 12 years ago

Owner: set to sev-

comment:4 by sev-, 12 years ago

Yes, in this particualr case I added special feature to AdvancedDetector to let EGA and VGA variants co-exist in a single directory. I suppose we can just extend mass detector to process this particular case. It is flagged by kADFlagUseExtraAsHint.

I cna take care of that if there are no objections.

comment:5 by SF/clemty, 12 years ago

What about games which allow setting the language internally? Would that mean that eventually HoF gets detected 3 times (English/French/German) or BASS gets even more entries? (Sorry if I'm missing the point here)

comment:6 by fingolfin, 12 years ago

Owner: changed from sev- to fingolfin
Status: newclosed

comment:7 by fingolfin, 12 years ago

That's precisely what we are doing these days.

comment:8 by digitall, 13 months ago

Component: GUI
Note: See TracTickets for help on using tickets.