Opened 14 years ago

Closed 14 years ago

Last modified 20 months ago

#7481 closed enhancement

Suggestion on how to cope with fan-translations

Reported by: SF/joachimeberhard Owned by: sev-
Priority: normal Component: --Other--
Keywords: Cc:


Hi ScummVM team,

I have a very simple suggestion on how to cope with fan-translations:

Simply check for a file md5.txt or target_md5.txt in the game directory.

This file would simply include one string, the md5 of the original game, which is the md5sum you would pass to target_md5.

So, check for the file target_md5.txt, read the string and pass it to target_md5 to detect the game properly.

It's simple, it wouldn't require any additional attention and it would really be simple to implement and maintain.

Now, whaddaya say to my suggestion?

It's so simple, I like it, and it would work. :D

Thanks, Joachim

Ticket imported from: #1450364. Ticket imported from: feature-requests/297.

Change History (9)

comment:1 by sev-, 14 years ago

In my eyes it is a nice and simple idea. i.e. translation patch program will automatically create that file and end-user will not have to edit scummvm.ini. I would implement it. Finglofin?

comment:2 by SF/joachimeberhard, 14 years ago

One further suggestion:

There could be a second string in that file, simply with the short abbreviation of the language of the translation.

You could then pass that to language, and set it up accordingly in the launcher.

Yeah, I love that idea. :D



comment:3 by SF/joachimeberhard, 14 years ago

And maybe name the file target_md5.ini or so, for consistency.

You could even pass your complete preferred scummvm.ini settings of a game, but that would probably go too far. ;) :D

comment:4 by fingolfin, 14 years ago

Personally, I still think that we can get get rid of the target_md5 hack, and automatically and fully detect all relevant game variants (except for the language) without using the MD5 checksum at all. That is, with the possible exception of the HE games, I do not yet know enough about them to say for sure (are there any projects out there to make fan translations of those?).

As it is, feel free to implement this hack. It certainly will work, but I do not like it anymore than I like the target_md5 approach -- it's just that as a typical geek, I prefer solutions to workarounds :-).

comment:5 by fingolfin, 14 years ago

Note: And yeah, I am aware that the new auto detection code still is vapor ware, sorry for that. Hopefully I'll soon have time to implement some more missing bits and pieces of it; in particular, I still need to implement the code that uses "extra_versions", and get rid of "multiple_versions_md5_settings". And more things <sigh>.

So, for the time being, if you feel that this is a very important and pressing issue, feel free to implement it now, just be prepared to see it removed one day again :-).

comment:6 by sev-, 14 years ago

So I implemented. A sample target_md5.txt file:

-- [target_md5.txt ---- 2d4536a56e01da4b02eb021e7770afa2 -----------------------

I.e. put only MD5 there. It reads first 32 bytes, rest is ignored.

comment:7 by sev-, 14 years ago

Owner: set to sev-
Status: newclosed

comment:8 by fingolfin, 14 years ago

For reference, target_md5 has now been removed again, since the new detector code (hopefully) made it obsolete. If things that used to work with target_md5 don't work for you anymore, consider filing a bug report (but make sure to read the bug submission guidelines first !!!).

comment:9 by digitall, 20 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.