Opened 16 years ago

Closed 16 years ago

Last modified 17 months ago

#7342 closed enhancement (wontfix)

SCUMM - Support for PCM pitch bends

Reported by: SF/quietust Owned by:
Priority: low Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

Several sound effects in Amiga Maniac Mansion and Zak McKracken perform pitch bends and, due to the current limitations of RateConverter, sound quite horrible. Fixing this would require either modifying the current RateConverter to allow changing the input sample rate or creating an additional converter with this ability. The main place this would be used would be in player_mod.cpp/h

Ticket imported from: #859301. Ticket imported from: feature-requests/158.

Change History (3)

comment:1 by SF/quietust, 16 years ago

Priority: normallow
Resolution: wontfix
Status: newclosed

comment:2 by fingolfin, 16 years ago

I see you closed this by yourself, whyever ?!?

In any case, as I tried to explain to you half a dozen times in IRC, changing the rate converter to do this is not he way it should be done. The rate converter (which BTW I wrote, you asked for it on IRC) is meant to only convert one fixed format of audio data to another fixed format, in a most efficient way.

What you want is an effect filter (in this case for variable pitch bending). While it would be possible to hack the rate converter to do this, it would be an abuse of the design. The proper way would be to write a separate filter class. Which could of course be based on the linear rate converter in rate.cpp, or on other code.

comment:3 by digitall, 17 months ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.