Opened 16 years ago

Closed 15 years ago

Last modified 12 months ago

#7321 closed enhancement (fixed)

AUDIO: ST sound

Reported by: SF/hibernatus Owned by: SF/hoenicke
Priority: normal Component: Audio
Keywords: Cc:
Game:

Description

PlayerV2 without the lowpass filter sounds very close to
the original ST engines.
So adding an option to disable the filter would be nice.
But is still doesn't sound perfect:

ST emulator without any filter:
http://hibernatus34.free.fr/pv/saint_raw.wav
ScummVM without the lowpass filter:
http://hibernatus34.free.fr/pv/scummvm_raw.wav

ST emulator with its (light) filter:
http://hibernatus34.free.fr/pv/saint_lowpass.wav
ScummVM with the filter:
http://hibernatus34.free.fr/pv/scummvm_lowpass.wav

(The ST emulator really sounds nearly perfect)

What's strange is that all the samples in the ScummVM
output are positive. Is it a bug?

Ticket imported from: #812913. Ticket imported from: feature-requests/137.

Change History (11)

comment:1 by eriktorbjorn, 16 years ago

Owner: set to SF/hoenicke

comment:2 by fingolfin, 16 years ago

Regarding your question: "What's strange is that all the samples in
the ScummVM output are positive. Is it a bug?"

-> it would seem to me that it is a bug, yeah. I noticed earlier
that Player_V2::squareGenerator generates only positive samples,
and wondered about it, but at that time didn't want to mess with
code that *seems* to work - rather let hoenicke do that :-).
Player_V2::lowPassFilter() also would have to be "fixed", I guesss,
maybe more.

comment:3 by SF/hoenicke, 16 years ago

Okay I looked what needs to be changed to get signed samples.
I will check it in as soon as I cleaned it up.

I'm not sure if it makes sense to add a global option for
something so specific as the low pass filter for -epcjr/-epcspk
engines. BTW, you can easily make the filter lighter by
decreasing PCJR_DECAY, maybe you can find a better setting.

comment:4 by SF/hibernatus, 16 years ago

I like how it sounds with PCJR_DECAY = 0xee80. But i don't
know if the other users would agree.
At least i can say it sounds closer to my memories.

comment:5 by fingolfin, 16 years ago

Summary: ST soundAUDIO: ST sound

comment:6 by fingolfin, 16 years ago

The "only positive samples" issue was correct, AFAICT.

comment:7 by SF/hoenicke, 16 years ago

Yes, the "positive samples" issue was corrected in cvs release
2.35 of player_v2.cpp.

comment:8 by SF/hoenicke, 15 years ago

The lowpass filter is now even more reduced, compare
"#1158455" where tbcarey compared it with a real PCjr.

comment:9 by SF/hoenicke, 15 years ago

Resolution: fixed
Status: newclosed

comment:10 by SF/hoenicke, 15 years ago

The lowpass filter is now even more reduced, compare
"#1158455" where tbcarey compared it with a real PCjr.

comment:11 by digitall, 12 months ago

Component: Audio
Note: See TracTickets for help on using tickets.