Opened 22 years ago

Closed 22 years ago

Last modified 6 years ago

#7235 closed feature request

More fade modes

Reported by: SF/logicdeluxe Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Loom

Description

I noticed that there are at least two more fade modes, which don't appear in ScummVM. This is in Loom and Monkey1 at almost every people close up. The screen should fades with graduate blocks. Check the people at the left screen inside the Scumm Bar! And the other is in Indy4 in the statue close up in the intro. And in all scenes where an eel figure melts. In the original ScummVM these fades are quite fast on pentium PCs so you hardly can notice them. Try an 80486 etc. or slow down tools, if you want to check them out! Maybe it help you for the fade issue in ZAK256, bug 596018, too. There is another thing: I don't know if this is a difference on ZAK256 compared to the EGA and c64 versions or if this is a ScummVM bug. I noticed that you do fade ins from edge to centre. On EGA and c64 fade ins however are done from centre to edge (the reversed way of fade outs)

Ticket imported from: #596788. Ticket imported from: feature-requests/51.

Change History (10)

comment:1 by eriktorbjorn, 22 years ago

Could you try with the latest CVS version? I submitted a patch for the Loom/Monkey1 and Indy4 fades that was applied recently, but I don't know if I got it right since I haven't actually *seen* these fade modes in action.

In particular, I suspect the Loom fades should use dissolveEffect(8, 4) instead of dissolveEffect(8, 8) since that seems to match the Amiga version more closely. Or maybe the CD version uses completely different fades?

comment:2 by SF/logicdeluxe, 22 years ago

Looks fine in Indy4. Monkey seems to use 8x4 blocks in all VGA, Amiga and enhaced CD. In LoomCD it is single pixel dissolve between screens when walking around. I'll have to check the close ups in LoomCD yet. I only saw this in the EGA version and the Amiga version where it were 8x4 blocks, as far I can remember that.

comment:3 by eriktorbjorn, 22 years ago

That's odd, because the close-ups in MI's SCUMM Bar and the "between screens" effect in LOOM CD use the same function, i.e. the one that used to be unkScreenEffect6() but which has now been replaced by a call to dissolveEffect(8, 8).

Of course it's trivial to make it game-dependent. Just replace the dissolveEffect(8, 8) call with something like

if (_gameId == GID_LOOM256) dissolveEffect(1, 1); else dissolveEffect(8, 4);

It just seems a bit strange when there already is another fade mode that calls dissolveEffect(1, 1).

But it's good to know that it already looks more-or-less correct. :-)

comment:4 by SF/logicdeluxe, 22 years ago

Sorry, my mistake: The Amiga version does no fade at all at these close ups. The close ups appear instantly there. I just checked this out. First I thought, they forgot to implement those fades, but then, if you restart with F8 a fade out happens with exacly those 8x4 blocks. Also strange: when restarting the enhanced CD it is the only time in MI a single-pixel-disolve happens, I think. The vga disk version also does 8x4 blocks when restarting.

comment:5 by eriktorbjorn, 22 years ago

Do the Loom / MI1 fades look right now?

comment:6 by eriktorbjorn, 22 years ago

Do the Loom / MI1 fades look right now?

comment:7 by SF/logicdeluxe, 22 years ago

Looks right for me.

comment:8 by SF/ender, 22 years ago

Owner: set to SF/ender
Status: newclosed

comment:9 by SF/ender, 22 years ago

Closing as these have been added :)

comment:10 by digitall, 6 years ago

Component: Engine: SCUMM
Game: Loom
Note: See TracTickets for help on using tickets.