Opened 18 years ago

Closed 17 years ago

Last modified 21 months ago

#7225 closed enhancement (fixed)

Support 44.1 khz mp3s

Reported by: (none) Owned by: fingolfin
Priority: normal Component: Audio
Keywords: Cc:
Game:

Description

Please support 44.1 khz mp3, this whould be cool especially for loom. The Quality of a 22.1 khz mp3 is not that good.

thx

Ticket imported from: #557937. Ticket imported from: feature-requests/41.

Change History (9)

comment:1 by fingolfin, 18 years ago

...and OGGs of course :-)

Note that this would require some major reworking of the mixer at the current state. Also, we can't just switch to 44khz output, we would have to keep both 44khz and 22khz possible, since the PocketPC version of ScummVM is already strained with 22khz audio - 44khz simply would be too much (talking in terms of processing power).

comment:2 by (none), 17 years ago

Hmm, in ZSNES it is possible to change this at runtime, maybe you can borrow some code there :-)

comment:3 by SF/pwigren, 17 years ago

Try using OGG/Vorbis instead! Loom sounds fine here, even at -q 0 (about 40 kbps !!!)

comment:4 by SF/logicdeluxe, 17 years ago

Integrating a multi sample rate mixer would make the resampling for monster.sog/monster.so3 obsolete. In addition it would enabling the optional use of 44.1 kHz ogg/mp3 CD tracks (Hence posting this here, since it is the main advantage of this.). The required real time resampling best could be done with a linear interpolation (fast) and a fft lowpass (not that fast) before downsampling (if this would the case at all) and after upsampling to the target rate in order to avoid alias and mirror frequencies. Since this would take a serious amount of CPU time, this should be an option. You still should be able doing all at 22050 Hz (or even lower, if you wish, as 11111 would be enough for FOA, for example), of course. The extract tool then would need a sort of --no-resample switch.

comment:5 by SF/arisme, 17 years ago

actually the PocketPC version is already downsampling to 11 kHz :)

comment:6 by SF/logicdeluxe, 17 years ago

Since you once wrote that the new mixer code can handle any output rates, please add a command line option and a scummvm.ini entry for this!

And think about it! Adding command line parameter to extract which let the user select the target rate would be a solution to the resampling issue in ScummVM (for monster.sou at least). Since the extract tool is not required to resample in real time it would be no problem there, ie it might take some hours without reducing the game experience. If ScummVM can use a sample rate of 44100 Hz it could be useful having a monster.sog/so3 with all sounds resampled to 44100 Hz, as well. That way ScummVM would not need to resample them anymore. That way it could sound even better than the hardware oversampling of many sound cards (including the SB Live!), which in deed often uses just linear interpolation like ScummVM. Since there are actually no frequencies above 22 kHz in monster.sou this wouldn't even increase the required bitrate. (You usually can encode a 22 kHz mp3 with almost the same size and quality in 44 kHz as well. I tried it with my discman, which also does badly resampling on low rates.) And not to forget that there are even recent sound cards which don't support low rates at all.

comment:7 by fingolfin, 17 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed

comment:8 by fingolfin, 17 years ago

Support for 44.1 khz MP3 playback has been added some weeks ago.

comment:9 by digitall, 21 months ago

Component: Audio
Note: See TracTickets for help on using tickets.