Opened 18 years ago

Closed 17 years ago

Last modified 17 months ago

#7205 closed enhancement

Conroy Bumpus' Song

Reported by: SF/logicdeluxe Owned by: SF/jamieson630
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max

Description

Built on Apr 25 2002 21:10:18 win German talkie

While Conroy Bumpus is singing his song, the midi version also is playing the same time. However the midi version should only play if there is no digital audio output available. Scummvm also does not play track3.mp3 if available. My original CD plays track 4 if I run the game directly from CD. The priority should be, cd audio/mp3 > monster.sou/monster.so3 > midi. But of course not more then one of them at the same time.

Ticket imported from: #548675. Ticket imported from: feature-requests/21.

Change History (10)

comment:1 by SF/baxslash, 18 years ago

I believe the digital version of the song is contained inside the monster.sou file. I discovered it by exploring the file with Scumm Revisited. Yes, there are music tracks on the CD, but I don't think the game has ever used them 'in-game'. (I could be wrong.) Either way, you are right: the midi should not play then if the digital audio is working right.

comment:2 by SF/logicdeluxe, 18 years ago

@baxslash

My original EXE plays this track, as I wrote. If I copy the game to harddisk it uses the version in monster.sou instead. Even there are more audio tracks on the CD, track 4 is the only used one by the game.

(btw. Monkey1 also contains unused tracks on the original CD.)

comment:3 by SF/ender, 18 years ago

Component: Engine: SCUMM
Game: Sam and Max

comment:4 by SF/ender, 18 years ago

Nothing we can currently do here. The imuse code we use is fairly different from the code used in sam and max.

Moving to feature requests, as this is not a viable bug to fix in the short term.

comment:5 by fingolfin, 17 years ago

Owner: set to SF/jamieson630

comment:6 by fingolfin, 17 years ago

Once more, this is something Jamieson seems to be working on... feel free to un-assign it from yo, though!

comment:7 by SF/jamieson630, 17 years ago

I'm not sure how the original LEC distribution handled Conroy's song in different cases. However, ScummVM intentionally plays both the MIDI file and the digital sound at the same time. The reason for this is that the digital sound cannot provide feedback to cue Conroy's movements from. The script is supposed to set the MIDI playback to 0 volume so that it plays, but silently. Until recently that was getting ignored in a lot of cases.

Recent changes to CVS fix the problem of the MIDI file not getting set to silent play properly, so you shouldn't be hearing it on top of the digi sound anymore. In addition, a hack to the script interpreter fixes a (non-iMuse-related) problem with Conroy's motion sequences getting hung up partway through the song.

Since the script that drives this is from the original LEC executable, I am inclined to believe that LEC's version also used a MIDI file running alongside the digi track to provide cueing information. That in itself bring up two interesting points:

(1) The MIDI playback timings must have been slightly different than the ones we are using, since our cues get progressively out of sync with the digi track, whereas I don't believe the LEC distr suffered from noticeable sync problems.

(2) The timings must have been identical even when using the OPL2 driver included with the LEC distr. This lends support for the concept of implementing Adlib (OPL2) support at the MidiDriver level rather than the IMuseDriver level. If we ever do that (I'm working on an experimental implementation now), we can better fine-tune the MIDI timings to deal with issues such as this.

Anyway.... I think that second point was a bit of a tangent. ;) As to why we never use the CD audio track -- I know very very little about the scripts in use for Conroy's song. Is CD audio support the "feature" that we're looking for here, then?

comment:8 by SF/jamieson630, 17 years ago

Since I'm not sure what we want to be accomplishing with this feature request, I am closing it for now. If someone can verify the use of the CD-audio version of Conroy's song in the original distro, and really really wants to see ScummVM support it for some reason, we can open a new feature request. This one has become too muddled with outdated bug information.

comment:9 by SF/jamieson630, 17 years ago

Status: newclosed

comment:10 by digitall, 17 months ago

Component: Engine: SCUMM
Game: Sam and Max
Note: See TracTickets for help on using tickets.