Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#7166 closed defect (fixed)

DRASCULA: Misleading indentation in animation.cpp

Reported by: DrMcCoy Owned by: criezy
Priority: low Component: Engine: Drascula
Keywords: Cc:
Game: Drascula

Description

GCC 6's -Wmisleading-indentation flags the if statement in engines/drascula/animation.cpp:130 to be misleadingly indented.

Specifically, this if statement is indented as if it belonged inside the for-statement in line 119. However, due to the lack of curly braces on that for-statement, this if-statement is not within the scope of that for-statement.

Ticket imported from: bugs/7166.

Change History (2)

comment:1 by criezy, 3 years ago

Owner: set to criezy
Resolution: fixed
Status: newclosed

comment:2 by criezy, 3 years ago

Thank you. That was an interesting one as this if statement should both belong to the for-statement started in line 119 and be outside of it :P

In essence there was one if statement missing, which caused a slight delay when interrupting the intro animation in the first scene with Igor. This is fixed with commit abb33e5.

Note: See TracTickets for help on using tickets.