Opened 4 years ago

Closed 3 months ago

#7125 closed defect (fixed)

GUI/AGI: Predictive dialog glitches when two buttons are pressed at once

Reported by: salty-horse Owned by: sev-
Priority: low Component: GUI
Keywords: Cc:
Game:

Description

Start an AGI game and click the text prompt line to open the predictive dialog. On the keyboard numpad, press two keys at once.

The corresponding on-screen buttons will changed to "pressed", but once the keyboard keys are released, only one of the on-screen buttons will change its state, while the other button will still show as pressed.

The predictive dialog only tracks one "pressed" button, so it can't handle several buttons being pressed. The code itself is rather confusing, with two variables having a similar name: _lastPressedButton and _lastPressed, so any should perhaps rename one of them.

A recent pull request removed the "sticky keys" feature, that affected the predictive dialog, but this problem existed before the change.

Ticket imported from: bugs/7125.

Change History (3)

comment:1 by sev-, 3 years ago

Component: GUI

comment:2 by aryanrawlani28, 3 months ago

I've tried to fix this issue here: https://github.com/scummvm/scummvm/pull/2154

This fix only allows for single key presses at a time.

comment:3 by sev-, 3 months ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

Fixed in 345520b8cb22b43a278520b84abca3da4b6349ee Thanks, aryanrawlani28

Note: See TracTickets for help on using tickets.