Opened 8 years ago

Closed 3 years ago

#7107 closed defect (fixed)

TOLTECS: Wrong "Cancel" behaviour

Reported by: raziel- Owned by: sev-
Priority: high Component: Engine: Toltecs
Version: Keywords:
Cc: Game: 3 Skulls of the Toltecs


ScummVM 1.9.0git (Apr 3 2016 18:48:44) Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC FreeType2 JPEG PNG

Being nitpicky here.

Once one starts the game and the "Warner Interactive" and "Revistronic" logos have passed, an in-game options window will open with options like Load, Save, Volume etc.

Clicking on the Volume settings brings up a new in-game page. Clicking on "Cancel" on this very page brings you back to the main options page.

Albeit that does not happen when one clicks on "Load" or "Save" as that will bring up the ScummVM internal Load/Save page.

That would be fine, but if one clicks on "Cancel" there it won't go back to the options page, but throw one right into the intro of the game...which is wrong imho, because if i wanted to load a game, but accidently clicked on save and just want to try again, i can't.

As i said, nitpicky ;-)

3 Skulls of the Toltecs (DOS/English)

AmigaOS4 - PPC - SDL - BE gcc (adtools build 5.3.0) 5.3.0

Ticket imported from: bugs/7107.

Change History (3)

comment:1 by eriktorbjorn, 8 years ago

This doesn't happen when using the original save/load dialogs, only ScummVM's.

As far as I can tell, this can be worked around in MenuSystem::initMenu(), where it currently always sets 'running' to false after callin dialog->runModalWithCurrentTarget(). If you only do so when slot >= 0, and set 'newMenuID' back to kMenuIdMain, it will work at the start of the game.

However, if you do that then you'll get the main menu in-game when cancelling a save/load dialog, which probably isn't desirable.

(I know there should be underscores before some of those identifiers, but GitHub seems to want to render that as italics and I can't be bothered to figure out how to suppress that.)

comment:2 by sev-, 4 years ago

Priority: normalhigh

comment:3 by sev-, 3 years ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

I implemented the proper behaviour. It returns to the main menu when Load/Save is called from the main menu and resumes the game otherwise when the Cancel button is pressed.

Note: See TracTickets for help on using tickets.