Opened 4 years ago

Closed 3 weeks ago

#7097 closed defect (fixed)

MOHAWK: Myst the game runs instead of The Making of Myst movie

Reported by: SF/ignalina Owned by: bgK
Priority: normal Component: Engine: Mohawk
Keywords: Cc:
Game:

Description

When you add the original Windows Myst to ScummVM, you usually get a choice of two targets: Myst the game and the movie "The Making of Myst". If you try to run the movie, however, the game will start instead.

This has apparently always been the case. Droid2727 complains about this on irc in 2011, here at 21:18:00, and again at 21:24 here.

When you think that you are telling ScummVM launcher menu to start "The Making of Myst", what you are actually doing is telling ScummVM to launch the first game it can find in the target directory that uses the same engine. In the case of the original Windows Myst CD, it will always be Myst the game, unless you rename or move the MYST.DAT file.

Ticket imported from: bugs/7097.

Attachments (1)

debug.log (438.9 KB ) - added by SF/ignalina 4 years ago.

Download all attachments as: .zip

Change History (10)

by SF/ignalina, 4 years ago

Attachment: debug.log added

comment:1 by SF/ignalina, 4 years ago

None of the links worked. Another try:

http://echelog.com/logs/browse/scummvm/1308952800
(Look at 21:18:00)

http://www.enderboi.com/log.php?log=scummvm.log.20Jan2012&format=html
(At 21:24)

comment:2 by sev-, 3 years ago

Component: Engine: Mohawk

comment:3 by dafioram, 2 years ago

Owner: set to dafioram
Resolution: outdated
Status: newclosed

If I add Myst to scummvm 1.10.0git-5274-gdb82345 (oct 26) it does not list two targets. I have myst.dat in my directory. So this can no longer be reproduced.

comment:4 by angstsmurf, 2 years ago

I can still reproduce this when adding Myst. I think the Making of Myst video is only included in the original 256-color Myst, not the Masterpiece edition.

comment:5 by bgK, 2 years ago

Resolution: outdated
Status: closednew

This is still occurring. The mohawk engine uses the singleId advanced detector feature, which means all the games use the same gameId. When launching Myst, ScummVM has insufficient data to decide whether to start the making of video or the game.

A branch reworking how ScummVM stores the game detection results in the configuration file can be found there: https://github.com/bgK/scummvm/commits/add-engineid2. It fixes the bug, but still needs some work.

comment:6 by dafioram, 2 years ago

Owner: changed from dafioram to bgK

comment:7 by dafioram, 2 years ago

Another option is to not include MAKING.DAT in your myst folder that scummvm checks. That is not required to play myst.

comment:8 by angstsmurf, 19 months ago

Just a clarification: this issue really has two separate parts: a) a usability problem, as the user might be confused by ScummVM creating two targets which both start the same game, and b) a limitation in the way ScummVM handles the detection of games.

a) is really the bigger problem in my view, and can be trivially fixed by commenting out the Making of Myst movie target in the code.

b) could be fixed by bgK's unfinished branch above, but might actually be overkill unless this limitation causes problems elsewhere.

comment:9 by bgK, 3 weeks ago

Resolution: fixed
Status: newclosed

This is fixed as of ScummVM 2.2.0git-653-g66dcf6b3d6. The Making of Myst targets in the launcher need to be removed and added again for proper behavior, though.

Note: See TracTickets for help on using tickets.