Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7092 closed defect (fixed)

IHNM: text color mistake in German fan-made version

Reported by: SF/windlepoons Owned by: sev-
Priority: normal Component: Engine: SAGA
Version: Keywords:
Cc: Game: I Have No Mouth


With the German fan-made version i found two color bugs.

  1. In the talk dialog the text and background are black, when hover this, the text and background is white. No problem in ScummVM with the Original English an German version. In DOSBox i see the original colors in the German fan-made version.

  2. Same in load/save slots

Before fix the bug #7064 the colors was fine (but not the text on the left side in the load/save dialog)

Here the German Fan patch for testing this. You need a Original English version. This patched the files S.EXE, SCREAM.RES and SCRIPTS.RES.

Version: I Have No Mouth and I Must Scream (fan-made/DOS/German)

ScummVM 1.9.0git (Mar 27 2016 12:56:01) Features compiled in: TAINTED Vorbis FLAC MP3 ALSA SEQ TiMidity RGB zLib MPEG2 FluidSynth Theora AAC FreeType2 JPEG PNG

Linux vienna 4.5.0-towo.1-siduction-amd64 #1 SMP PREEMPT siduction 4.5-2 (2016-03-14) x86_64 GNU/Linux

Ticket imported from: bugs/7092.

Attachments (2)

ihnm-dosbox-fan-de.png (123.4 KB ) - added by SF/windlepoons 8 years ago.
ihnm-scummvm-fan-de.png (120.4 KB ) - added by SF/windlepoons 8 years ago.

Download all attachments as: .zip

Change History (5)

by SF/windlepoons, 8 years ago

Attachment: ihnm-dosbox-fan-de.png added

comment:1 by eriktorbjorn, 8 years ago

Since this is apparently based on the English version, it probably shouldn't have the colour corrections made for the official German version. Se commit 0a5a722b027303e29b486e146a580f7881ca2a2d and/or the comments made in Interface::drawStatusBar() and SagaEngine::KnownColor2ColorId().

At the moment, it doesn't look like we can distinguish between these versions. So I guess we should either add a "fan made" feature flag, or a new field in the game description for the original language.

comment:2 by SF/windlepoons, 8 years ago

I have now the stable source (1.8.0) compiled with the fan-made checksum. This build without fixed for #7064 has no text mistakes.

The fix #7064 works with the Original German version, without the fix no problem with the German fan-made version (based on English version).

comment:3 by sev-, 8 years ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

comment:4 by sev-, 8 years ago

Right. Now I added special game flag and marked only required versions. Please retest.

Note: See TracTickets for help on using tickets.