Opened 8 years ago

Closed 3 years ago

#7066 closed defect (fixed)

MOHAWK: LB - Error at start of Just Grandma and Me (German)

Reported by: SF/mattn81 Owned by: besentv
Priority: normal Component: Engine: Mohawk
Version: Keywords:
Cc: Game:

Description

ScummVM 1.7.0 & 1.8.1pre12

When starting the German windows version of "Grandma and Me" from the living books 1 bundle version 2 I get the following error:

ERROR: INIFile::loadFromStream: Invalid character 'ö' occured in the section name in line 63!

When I start the English version and choose the German language from the menu the whole book is working perfectly from start to end. It seems as if only the German menu is the problem.

Ticket imported from: bugs/7066.

Change History (6)

comment:1 by bonki, 5 years ago

Summary: Error at start of Grandma and Me windows GermanLB: Error at start of Just Grandma and Me (German)

Thanks for your report!

This happens because our INI-parser (common/ini-file.cpp) currently doesn't allow non-alphanumeric characters in section names.

As an aside, the 2.0 version is still considered unstable and thus unsupported.

comment:2 by raziel-, 4 years ago

Adding a duplicate for sake of completeness #10949

MOHAWK: Just Grandma and Me - only English starts, German and French doesn't

==============================================================

Configuration:
OS: all Windows
ScummVM Version: all (2.1.0git-5236 and all older)
Game: Just Grandma and Me (CD Version)
Language: English/French/German
Reproducibility: 100% on different Windows OS (WinXP,7,8.1/10) german/english
Bug Description:
Starting the game in german ends with:
ERROR: INIFile::LoadFrameStream: Invalid character 'ö' occured in section name in line 63!
Starting the game in french ends with:
ERROR: INIFile::LoadFrameStream: Invalid character 'ç' occured in section name in line 63!
Analysis:
Line 63 of german file "JGMD.LB" is [Französisch.Play]
Line 63 of french file "JGMF.LB" is [Français.Play]
The problem seems to be caused by the special characters "ö" (german) and "ç" (french) which are used in the corresponding files.

comment:3 by raziel-, 4 years ago

Summary: LB: Error at start of Just Grandma and Me (German)MOHAWK: LB - Error at start of Just Grandma and Me (German)

comment:4 by besentv, 3 years ago

The game works in German and French when you change 2 lines in /common/ini-file.cpp:

Line 35:

while (*p && (isAlnum(*p) || *p == '-' || *p == '_' || *p == '.' || *p == ' ' || *p == '\xF6' || *p == '\xE7'))

Line 112:

  while (*p && ((_allowNonEnglishCharacters && *p != ']') || isAlnum(*p) || *p == '-' || *p == '_' || *p == '.' || *p == ' ' || *p == '\xF6' || *p == '\xE7'))

Here is an image of my custom build: (Not sure if it breaks sth else)

https://i.imgur.com/fgKAric.png


Last edited 3 years ago by besentv (previous) (diff)

comment:5 by raziel-, 3 years ago

@besentv

Could you add a pull request of your changes to https://github.com/scummvm/scummvm/pulls

That way devs are able to review it and give feedback.

Bug reports are great, but tend to not get the love they deserve

comment:6 by besentv, 3 years ago

Owner: set to besentv
Resolution: fixed
Status: newclosed

This has been fixed a while ago in this commit.

Note: See TracTickets for help on using tickets.