Opened 4 years ago

Closed 3 months ago

#7050 closed defect (fixed)

SCI: PHARKAS Mac showing incorrect cursor

Reported by: SF/eisnerguy1 Owned by: sluicebox
Priority: normal Component: Engine: SCI
Keywords: has-pull-request Cc:
Game: Freddy Pharkas: Frontier Pharmacist

Description

Freddy Pharkas: Frontier Pharmacist (Macintosh/English)
Tried in:
ScummVM 1.7.0
ScummVM 1.8.0pre170-g269aeb1
ScummVM 1.9.0git703-g748b768

Mac OS X 10.10.5

In Freddy Pharkas, there's a "wait" cursor icon. ScummVM seems to be loading the part of the cursor icon. It's loading the first "frame" when it should be loading the second "frame". I've attached screenshots on how it looks in the ScummVM versions listed above and also a recording of how it's supposed to look in game (when played using SheepShaver).

Ticket imported from: bugs/7050.

Attachments (9)

1.7.0.png (82.0 KB ) - added by SF/eisnerguy1 4 years ago.
1.8.0pre.png (78.8 KB ) - added by SF/eisnerguy1 4 years ago.
1.9.0git.png (78.9 KB ) - added by SF/eisnerguy1 4 years ago.
cursor.mov (10.5 MB ) - added by SF/eisnerguy1 4 years ago.
cursor_icon_4x.png (404 bytes ) - added by SF/eisnerguy1 4 years ago.
Scaling_Intro_DOS_Floppy_Master.mov (8.7 MB ) - added by SF/eisnerguy1 4 years ago.
Scaling_Intro_Mac_Master.mov (20.0 MB ) - added by SF/eisnerguy1 4 years ago.
Scaling_Intro.mov (11.9 MB ) - added by SF/eisnerguy1 4 years ago.
Scaling_Intro_mini_vMac.mov (10.8 MB ) - added by SF/eisnerguy1 4 years ago.

Change History (20)

by SF/eisnerguy1, 4 years ago

Attachment: 1.7.0.png added

by SF/eisnerguy1, 4 years ago

Attachment: 1.8.0pre.png added

comment:1 by SF/eisnerguy1, 4 years ago

Here's the screenshot for 1.8.0pre

by SF/eisnerguy1, 4 years ago

Attachment: 1.9.0git.png added

comment:2 by SF/eisnerguy1, 4 years ago

Here's the screenshot for 1.9.0git

by SF/eisnerguy1, 4 years ago

Attachment: cursor.mov added

comment:3 by SF/eisnerguy1, 4 years ago

Here's the recording of the game when played in SheepShaver

by SF/eisnerguy1, 4 years ago

Attachment: cursor_icon_4x.png added

comment:4 by SF/eisnerguy1, 4 years ago

And here's the extracted cursor icon in question. Oh & whoops, forgot to select the " SCI: Freddy Pharkas: Frontier Pharmacist" milestone when submitting this ticket.

comment:5 by lordhoto, 4 years ago

Component: Engine: SCI
Game: Freddy Pharkas: Frontier Pharmacist

comment:6 by m-kiewitz, 4 years ago

Hi, this is not directly related to this specific bug, but I just hopefully fixed the title not scaling in and just appearing, but I can't test the Mac version, because I don't own it and another developer has just bought it, but it will take quite a bit to arrive. Can you please try the latest ScummVM master and check, if the intro is scaling properly now for the Mac version too?

by SF/eisnerguy1, 4 years ago

Attachment: Scaling_Intro.mov added

comment:7 by SF/eisnerguy1, 4 years ago

Just compiled from commit d390a63cd2a8bc812e3a460c2bec7b6df3c8ef3a. The Mac game version now scales like the DOS Floppy & DOS CD-ROM versions. But, it scales slowly. I've included a screen recording of how the native Mac version looks (while playing it in SheepShaver). It looks like there's almost no scaling of the intro logo. It just pops in place like it did before your change in the ScummVM code.

I've also included screen recordings of how the Mac intro looks now and the DOS floppy intro, while using the compiled master source.

comment:8 by m-kiewitz, 4 years ago

It depends on the power of the computer. When the computer is too fast, the scaling will be almost instant, because Sierra had no delays or anything, when scaling. So you either get that using SheepShaver, or maybe even Sierra's interpreter on Mac had issues with that specific code and didn't show the inbetween frames. I could change Sierra's code to make it faster. We delay for 30 ms per frame. Still in DOSBox I think it's even slower, when using 3000 cycles.

by SF/eisnerguy1, 4 years ago

Attachment: Scaling_Intro_mini_vMac.mov added

comment:9 by SF/eisnerguy1, 4 years ago

Yeah, you're right. So, I've been running Freddy Pharkas in Mini vMac (the 3.4.0 alpha) (it emulates a Macintosh II), and the logo does scale at about the same speed as the current ScummVM master code. I've attached a screen recording below.

comment:10 by eisnerguy1, 3 years ago

The issue with the cursors still exists in ScummVM 1.9.0 (Oct 11 2016 19:58:14). Running it on 10.10.5.

comment:11 by sluicebox, 3 months ago

Keywords: has-pull-request added
Owner: set to sluicebox

https://github.com/scummvm/scummvm/pull/1816

Affects KQ6 Mac cursors too (though not as obviously)

comment:12 by Filippos Karapetis <bluegr@…>, 3 months ago

In 60fcf993:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:13 by bluegr, 3 months ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.