Opened 3 years ago

Closed 3 years ago

Last modified 7 months ago

#7009 closed defect (fixed)

SCI: Not able to use Fx keys and key combos anymore

Reported by: raziel- Owned by: m-kiewitz
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game:

Description

ScummVM 1.8.0git (Jan 29 2016 19:00:53)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC FreeType2 JPEG PNG

All of the SCI Games seems to have lost the ability to use either the F keys or the CTRL+ key combos (i.e.CTRL+s sound on/off)

F1 up to F12 just do nothing, while the CTRL+ combos simply display the combo key (i.e. s) in the command parser as first word of a command.

DosBox and the orignal interpreter use those keys as meant for the menu items.

AmigaOS4 - PPC - SDL - BE
gcc (adtools build 5.3.0) 5.3.0

Ticket imported from: bugs/7009.

Change History (11)

comment:1 Changed 3 years ago by m-kiewitz

works for me on Windows

comment:2 Changed 3 years ago by m-kiewitz

I reversed a keyboard handling commit, that I made a few days ago.
Please try again. It seems it's either an issue in our SDL backend or SDL itself (or both).

comment:3 Changed 3 years ago by raziel-

No change in behaviour, i'm afraid

comment:4 Changed 3 years ago by wjp

When was the last time it did still work?

comment:5 Changed 3 years ago by raziel-

I'll try bisecting it manually, bear with me

comment:6 Changed 3 years ago by raziel-

f945965 broke it
44e2256 is fine

comment:7 Changed 3 years ago by m-kiewitz

Does it happen for SCI1 games too? for example Larry 5 etc.?

comment:8 Changed 3 years ago by raziel-

Nope.

CTRL-Q (Quit) and F5/F7 still work in those games

comment:9 Changed 3 years ago by m-kiewitz

This should now be solved by commit c0bdbe1ca88967bddd877e14d1e99d3fedaf715e

The bisected commit was actually correct. The commit just caused another issue to happen, because Sierra didn't check modifiers for menu keys - but we do.

Detailed information here: https://github.com/scummvm/scummvm/commit/c0bdbe1ca88967bddd877e14d1e99d3fedaf715e

comment:10 Changed 3 years ago by m-kiewitz

Owner: set to m-kiewitz
Resolution: fixed
Status: newclosed

comment:11 Changed 7 months ago by digitall

Component: Engine: SCI
Note: See TracTickets for help on using tickets.