Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6858 closed defect (fixed)

AGI: KQ1 PCjr sound lacks volume envelopes

Reported by: SF/eyeball226 Owned by: criezy
Priority: normal Component: Engine: AGI
Keywords: Cc:
Game: King's Quest 1

Description

In the '87 DOS version of KQ1, the PCjr/Tandy music (Greensleeves) seems to be missing its volume envelopes, that is to say that all channels are playing at full volume all the time 'organ style'.

I'm using ScummVM 1.7.0 release on Windows 8.1 x64 with the English, 2.0F 1987 DOS version of KQ1.

Almost certainly being emulated on DOSBox, but this is an example of how I'd expect it to sound: https://www.youtube.com/watch?v=ywIW8mf3l1Y

I originally made a thread here: http://forums.scummvm.org/viewtopic.php?p=81487#81487 The suggestion was to report it as a bug.

Ticket imported from: bugs/6858.

Change History (3)

comment:1 by criezy, 5 years ago

I was investigating this after seeing the forum post and I think I found a regression from August 2011 (so older version of ScummVM - such as 1.3.1 - may work better).

I opened a pull request that attempts to fix that regression: https://github.com/scummvm/scummvm/pull/594

comment:2 by criezy, 5 years ago

Owner: set to criezy
Resolution: fixed
Status: newclosed

comment:3 by criezy, 5 years ago

I fixed a couple of regressions in our AGI PCjr code today. I also modified the way it handles the Music/SFX volumes from the GUI. I think this should fix this bug. You can check this is the case tomorrow (or later) with the next daily build from http://www.scummvm.org/downloads/#daily

Note: See TracTickets for help on using tickets.