Opened 5 years ago

Closed 18 months ago

#6838 closed defect (fixed)

SCUMM: Manual Saving Allowed in AutoSave slot

Reported by: SF/deejaydiabolik Owned by: bonki
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

I have tryed whit DailyBuild... but i thinks every version has been affected by this BUG.... and i thinks we can reproduce it whit every version on every supported games :)

I have also tryed it usually for SCUMM Games in games when it's possibly to Save using F5 Button.... how to reproduce:
- Start a game whitout any previous savegame... ex MI1
- Open F5 menù
- Select SAVE

At this point this savegames it's been stored to SLOT 0 and not on SLOT 1... the SLOT 0 it's the slot used by AutoSave (usually and default setted to every 5 minutes) on all SCUMM Games, only whit this motive i thinks it's a general bugs :)

I have also tryed and find the same function whit this title:
- Monkey Island 2
- Indy Fate of Atlantis and Last Crusade
- Zak McKraken

It's 3 title using SCUMM :)

Ticket imported from: bugs/6838.

Change History (8)

comment:1 by digitall, 5 years ago

Summary: Now it's possible to save into AutoSave dedicated slot... it's a bug ?ALL: Manual Saving Allowed in AutoSave slot

comment:2 by digitall, 5 years ago

The normal response to this is "Don't save in the Autosave slot".

Will leave this open as we should consider preventing "manual" saving in the autosave slot for all engines in future.

comment:3 by SF/deejaydiabolik, 5 years ago

Yeah..... but it's not possibly, at the fist savegames it's ever used the autosave slot......

comment:4 by lordhoto, 5 years ago

Summary: ALL: Manual Saving Allowed in AutoSave slotSCUMM: Manual Saving Allowed in AutoSave slot

comment:5 by lordhoto, 5 years ago

This is definitely not affecting all engines. A lot of engines seem to be setting the write protected flag for some of the slot ids (usually slot 0). A quick scan reveals that AGI, BBVS, CGE, CGE2, Drascula, Hugo, Kyra, Mortevielle, ZVision seem to set it for some slots (note that not all might be auto-saves). Thus I mark this as SCUMM only, other engines not protecting special save ids should get their own bug report.

comment:6 by sev-, 3 years ago

Component: Engine: SCUMM

comment:7 by bonki, 18 months ago

Is there a particular reason why this has not been fixed yet? All (?) other engines seem to properly set the write/delete protection flag for special slots.

I'm happy to commit this literally single LOC, but as this has been open for so long I'm afraid I might be missing something?

comment:8 by bonki, 18 months ago

Owner: set to bonki
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.