Opened 5 years ago

Closed 5 years ago

Last modified 2 years ago

#6593 closed defect (fixed)

VOYEUR: Actor names are jumping in the intro

Reported by: sylvaintv Owned by: dreammaster
Priority: normal Component: Engine: Voyeur
Keywords: Cc:
Game: Voyeur

Description

On the latest daily build on Windows 7 64bits, during the opening video, there is a problem with the actor names that are displayed in white color. The last name reappears for one frame before disappearing and displaying the new one.

ScummVM Version 1.7.0git6565-gd9112a5 (May 20 2014 04:10:29)
Windows x64
Voyeur (DOS/English)

Ticket imported from: bugs/6593.

Change History (7)

comment:1 by digitall, 5 years ago

Replicated with latest git master on Linux x86_64. Will investigate.

sylvaintv: Could you try this in DOSBox with the original interpreter and see if this happens there? Thanks.

comment:2 by digitall, 5 years ago

Owner: set to dreammaster

comment:3 by digitall, 5 years ago

Ah. This is dealt with in the function void VoyeurEngine::doOpening() at line 435 of engine/voyeur/voyeur.cpp. It is likely something is a little off in the creditsShow logic around line 485:
https://github.com/scummvm/scummvm/blob/master/engines/voyeur/voyeur.cpp#L485

comment:4 by sylvaintv, 5 years ago

Checked in DOSBox, the problem doesn't appear there.

comment:5 by digitall, 5 years ago

sylvaintv: Thanks for confirming. I tried several code changes to fix:

  1. Qualifying the textPic block where the credit is drawn to the screen with !creditShow. This didn't make any difference.

  2. Moving this block within the check if read for the next frame trigger block. The credit flashed up and then was immediately overdrawn, but the same double credit was shown.

This only seems to happen after the first few credits and a debug print shows that creditShow logic seems to be working correctly.. Would probably need to trace the frame trigger in the loop and see what exactly is happening at that point.

comment:6 by dreammaster, 5 years ago

Resolution: fixed
Status: newclosed

comment:7 by dreammaster, 2 years ago

Component: Engine: GobEngine: Voyeur
Note: See TracTickets for help on using tickets.