Opened 6 years ago

Closed 23 months ago

Last modified 23 months ago

#6548 closed defect (invalid)

COMPOSER: Gregory French Crash

Reported by: SF/georgeqgreg Owned by: sev-
Priority: blocker Component: Engine: Composer
Keywords: has-pull-request Cc:
Game:

Description

The French version of Gregory (100% malin) is recognized as English, then crashes immediately on start. Here's the ScummVM command output:

User picked target 'gregory-win-1' (gameid 'composer')...
Looking for a plugin supporting this gameid... Magic Composer Engine
Starting 'Composer Game'
failed to open '../data/page99.rsc'!

MD5 of BOOK.INI:

e54fc5c00de5f94e908a969e445af5d0 F:\PROGRAMS\BOOK.INI offset 0-2233

And PAGE99.RSC:

2eec2f188fb6646ecc10fb46368f324e F:\DATA\PAGE99.RSC offset 0-4999

Ticket imported from: bugs/6548.

Change History (13)

comment:1 by SF/georgeqgreg, 6 years ago

I think I must be stupid. Anyway, this is in the latest git. Anything else I forgot, yell at me.

comment:2 by digitall, 6 years ago

Summary: Gregory French version crash and MD5COMPOSER: Gregory French Crash

comment:3 by digitall, 6 years ago

Assume this game is http://wiki.scummvm.org/index.php/Gregory_and_the_Hot_Air_Balloon ?

comment:4 by fuzzie, 3 years ago

Owner: set to fuzzie

comment:5 by misterhands, 3 years ago

The Windows French version of Gregory and the Hot Air Balloon is still recognized as English.

I had the same crash (failed to open '../data/page99.rsc'!),
but moving the resource files to a data directory fixed it.

BTW the Composer games are not listed on the datafiles page.

Thanks !

comment:6 by csnover, 2 years ago

Priority: normalblocker

Raising all identified crasher, hang, and memory violation bugs which I could not fully triage myself to blocker priority for the next release.

comment:7 by csnover, 2 years ago

Owner: fuzzie removed

Removing all owners from release blockers so they can be reclaimed during the release process. If you are the previous owner and would graciously fix this bug for the next release, please go ahead and re-add yourself as owner.

comment:8 by bgK, 2 years ago

The game should now be detected with the proper language (fixed in commit 0b28ea98840).

comment:9 by csnover, 2 years ago

Keywords: has-pull-request added
Owner: set to bgK

comment:11 by sev-, 23 months ago

Owner: changed from bgK to sev-
Resolution: invalid
Status: newclosed

What I see here is that the user first installed the game and then tried to launch it.

On installation he got files in:

F:\PROGRAMS\BOOK.INI
F:\DATA\PAGE99.RSC

Detection works on book.ini, so ScummVM assumed that the files sit in F:\PROGRAMS, and then it was unable to open DATA directory.

The proper setup is to copy the CD contents, so that DATA directory is within PROGAMS directory.

Current code works well with ../ paths, as it is handled by normalizePath() called from backends/fs/posix/posix-fs.cpp.

comment:12 by bgK, 23 months ago

I guess from the bug report that F: is the cd-rom drive, and the user is trying to run the game straight from the CD. Which should work ... but obviously doesn't.

Last edited 23 months ago by bgK (previous) (diff)

comment:13 by sev-, 23 months ago

Ha! I was lazy for checking the original media. Indeed you are right. I just fixed it properly. Thanks for pointing!

Note: See TracTickets for help on using tickets.