Opened 6 years ago

Closed 5 weeks ago

#6532 closed defect (fixed)

WME: Art of Murder - Wrong Entry name and data md5sums

Reported by: raziel- Owned by: lolbot-iichan
Priority: normal Component: Engine: Wintermute
Keywords: has-pull-request, detection Cc:
Game: Wintermute

Description

ScummVM 1.7.0git (Feb 9 2014 16:00:19)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC FreeType2 JPEG PNG

I'll get these message upon adding and starting Art of Murder - FBI Confidential

The game in 'Games:GamesVM/Wintermute/FBI Confidential/game.url' seems to be unknown.
Please, report the following data to the ScummVM team along with name
of the game you tried to add and its version/language/etc.:
{"data.dcp", 0, "7e4c1dc8b1fb08541f7784d6288acfc8", 633692059},

User picked target 'wmefan-Art_of_Murder-win' (gameid 'wintermute')...
Looking for a plugin supporting this gameid... Wintermute
Starting 'Wintermute engine game'
The game in 'Games:GamesVM/Wintermute/FBI Confidential/game.url' seems to be unknown.
Please, report the following data to the ScummVM team along with name
of the game you tried to add and its version/language/etc.:
{"data.dcp", 0, "7e4c1dc8b1fb08541f7784d6288acfc8", 633692059},

The game has also a pretty wrong looking name entry, it gets detected as

[wmefan-Art_of_Murder-win]
platform=windows
gameid=wintermute
description=/aom0817/Art of Murder - FBI Confidential (fangame) (Windows)

I don't know where that /aom0817/ comes from

AmigaOS4 - PPC - SDL - BE
gcc (GCC) 4.2.4 (adtools build 20090118)

Ticket imported from: bugs/6532.

Change History (8)

comment:1 Changed 6 years ago by somaen

/aom0817/ is a translation tag, since the game detects through the fallback detection scheme (thus the "(fangame)"), it grabs the Caption-field from the startup-settings for the game, and uses that as a game title. A localized game will have tags like that in it's strings to allow for replacing the strings with the localized equivalents, but the fallback detector does not have any logic in place to care about such things. (nor is it a priority to add any such logic, as the fallback detector is meant to be just that, a fallback).

comment:2 Changed 6 years ago by bluegr

I've made a small patch for this. If the translation tags are like that in all localized entries, it should work with all localized games:

http://pastie.org/private/sqsel3aylj2jxnxto11ua

comment:3 Changed 6 years ago by raziel-

Thanks Filipos (again) :-)

I will try as soon as i get the chance.

But:
I checked at the WME games page ( http://res.dead-code.org/doku.php/games:start ) and Art of Murder is said to be 2.5D and may also be out of scope of ScummVM.

If it is, once again, sorry for the item and the extra work.

I should really have checked before i put all those items up

comment:4 Changed 6 years ago by bluegr

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:5 Changed 6 years ago by bluegr

Fixed in commit a1dea147bba16006b1fb45f9ae22b7d7a008d99e, after talking with somaen. The translation tags are now removed from entries taken from the fallback detector.

This game is out of ScummVM's scope, as it's a 2.5D game. Thus, I'm closing this as fixed

comment:6 Changed 5 weeks ago by lolbot-iichan

Resolution: fixed
Status: closednew

Reopening since we are now adding 2.5D to detection table.

comment:7 Changed 5 weeks ago by lolbot-iichan

Keywords: has-pull-request detection added
Owner: changed from bluegr to lolbot-iichan

comment:8 Changed 5 weeks ago by bluegr

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.