Opened 11 years ago

Closed 5 years ago

Last modified 5 years ago

#6488 closed defect (fixed)

WME: Dirty Split - no subtitles after intro

Reported by: misterhands Owned by: tobiatesan
Priority: normal Component: Engine: Wintermute
Version: Keywords: has-pull-request
Cc: Game: Wintermute

Description

Latest Win64 nightly Dirty Split FR

At the end of the intro during the phone conversation, no subtitles are shown. They are shown in the original.

Ticket imported from: bugs/6488.

Change History (15)

comment:1 by misterhands, 11 years ago

Oopss forgot the milestone. I can't edit it anymore though...

comment:2 by SF/tobiatesan, 11 years ago

According to somaen it's a missing feature (we don't handle the subtitle file in FMV's). I'll have a look and update you sometime next week.

comment:3 by somaen, 10 years ago

Component: Engine: Wintermute
Game: Wintermute

comment:4 by somaen, 10 years ago

Indeed, there is no FMV-subtitle support yet.

comment:5 by SF/tobiatesan, 10 years ago

I've started porting the subtitle code from WME1.

I'll keep you posted :)

comment:6 by misterhands, 10 years ago

Cool thanks!

comment:7 by SF/tobiatesan, 10 years ago

I think I'm close to have something satisfactory, expect a pull request sometime during the next 5 days.

comment:8 by misterhands, 10 years ago

Thanks for the PR, let me know if you need any testing after the merge.

comment:9 by somaen, 10 years ago

Owner: set to somaen

comment:10 by lolbot-iichan, 5 years ago

Owner: changed from somaen to lolbot-iichan
Resolution: outdated
Status: newpending

Works for me on both ScummVM 2.0.0 and dayly build.
Seems to be fixed ages ago.

comment:11 by lolbot-iichan, 5 years ago

Owner: changed from lolbot-iichan to somaen

comment:12 by lolbot-iichan, 5 years ago

Owner: changed from somaen to tobiatesan

comment:13 by lolbot-iichan, 5 years ago

I think I'm close to have something satisfactory, expect a pull request sometime during the next 5 days.

t0by, do you know if PR from comment:7 was actually integrated?

comment:14 by lolbot-iichan, 5 years ago

Resolution: outdatedfixed
Status: pendingclosed

Found the mentioned PR: https://github.com/scummvm/scummvm/pull/437
Closing bug as fixed by tobiatesan.

comment:15 by lolbot-iichan, 5 years ago

Keywords: has-pull-request added
Note: See TracTickets for help on using tickets.