Opened 10 years ago
Closed 10 years ago
#6469 closed defect (fixed)
TINSEL: DW1 - No Sfx/Voice in German 4 Lang GRA Version
| Reported by: | lordhoto | Owned by: | lordhoto |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Tinsel |
| Version: | Keywords: | ||
| Cc: | Game: | Discworld |
Description
ScummVM version: git 56cf0ccabb56fcea3e6633e17765d617ac227505, 1.6.0 release Language of game: 4 language (German, Spanish, French, Italian) Version of game: CD release with GRA files Platform and Compiler: Linux/amd64, g++ 4.8.2
As indicated in the title there are no (digital) sfx/voices for me when playing Discworld. The first place to notice this is when the TWG logo is shown. There's also no digital sfx/voices in the intro AFAICT. Last but not least, there's no sfx/voices in game in the first room of the game.
I tried ScummVM 1.6.0 and 1.5.0 and it seems it works just fine in 1.5.0. Thus, the regression must've been introduced somewhen in between.
Ticket imported from: bugs/6469.
Change History (9)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
| Summary: | DW: No Sfx/Voice in GRA Version → TINSEL: DW1 - No Sfx/Voice in GRA Version |
|---|
comment:3 by , 10 years ago
Odd, but with the latest development master and v1.6.0, I have no problems with voices/SFX in the Demo with GRA files ie. https://sourceforge.net/projects/scummvm/files/demos/tinsel/dw-dos-cd-demo-en.zip/download
comment:4 by , 10 years ago
This is very strange. There weren't any changes concerning sound in the GRA version. My English GRA CD works fine
comment:5 by , 10 years ago
Odd, but with the latest development master and v1.6.0, I have no problems with voices/SFX in the Demo with GRA files ie. https://sourceforge.net/projects/scummvm/files/demos/tinsel/dw-dos-cd-demo-en.zip/download
I can confirm that it works in that demo.
I'll try to bisect which commit introduced this regression.
comment:6 by , 10 years ago
It looks like the offending commit is: commit d4a354c17f811faa916bf548a11a88cb51c3b7b2 Author: Filippos Karapetis
md5@…
Date: Sun Jul 15 14:55:06 2012 +0300
TINSEL: Remove the GF_CD and GF_FLOPPY flags
It looks like the ADGF_CD flag wasn't added to the German detection entry (which I am using) and thus it thought it's a floppy version. I'll commit a fix for this.
comment:7 by , 10 years ago
| Summary: | TINSEL: DW1 - No Sfx/Voice in GRA Version → TINSEL: DW1 - No Sfx/Voice in German 4 Lang GRA Version |
|---|
comment:9 by , 10 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Can you try bisection when you have time?
V1.5.0 is 39b06605dd4cde10d248bbdd0ca37c4d387266e6
I have checked through the commits and there is nothing obvious so this is probably another breakage from the DW1 Mac BE changes.
I can't debug with this as I have the SCN version of DW1... However, the dw-dos-cd-demo-en comes with GRA files... so will try to bisect with this.