Opened 5 years ago

Closed 5 years ago

#6447 closed defect (fixed)

SCI: SQ4 - Crash within Hint Book

Reported by: SF/boneosaurusrex Owned by: m-kiewitz
Priority: normal Component: Engine: SCI
Keywords: script Cc:
Game: Space Quest 4

Description

When viewing the hint book, clicking the hint book navigation buttons with any action other than the hint book revealer or the hand crashes the game in ScummVM. For example, when clicking the look action on the exit button the message is:

Uninitialized read for temp 0 from method exitBut::doVerb (room 397, script 708, localCall ffffffff)!

To reproduce:

1. Open the hint book. (The action is automatically set to hint book revealer.)
2. Switch to the look action and click the exit button.
3. The message "Press this button to put the hint book away." appears. Click to dismiss it.
4. The game crashes and the ScummVM console appears.

Similar results occur when clicking the "prev" or "next" buttons and when using the actions walk, talk, smell, etc.

I don't know if this is relevant, but I've noticed that once obtaining the hint book, saving the game (and loading that game) prints to the console:

WARNING: Failed to locate base object for object at 0055:0C96; skipping!
WARNING: Failed to locate base object for object at 0065:1B04; skipping!
WARNING: Failed to locate base object for object at 0065:2284; skipping!
WARNING: Failed to locate base object for object at 0065:12E2; skipping!
WARNING: Failed to locate base object for object at 0065:20B6; skipping!
WARNING: Failed to locate base object for object at 0067:080A; skipping!

Attached are save games right before and after picking up the hint book.

ScummVM: 1.6.0 and 1.7.0 Nightly Win32.
SQ4: 1.1 English Floppy

I also tried with the 1.5.0 iPhone build and it did not crash.

Ticket imported from: #3615183. Ticket imported from: bugs/6447.

Attachments (2)

sq4.015 (45.1 KB) - added by SF/boneosaurusrex 5 years ago.
Save game right before getting the hint book
sq4.016 (48.2 KB) - added by SF/boneosaurusrex 5 years ago.
Save game right after getting the hint book

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by SF/boneosaurusrex

Attachment: sq4.015 added

Save game right before getting the hint book

Changed 5 years ago by SF/boneosaurusrex

Attachment: sq4.016 added

Save game right after getting the hint book

comment:1 Changed 5 years ago by m-kiewitz

was a script bug, solved by workaround
commit #297d5764fd89a2cad540c390563e119eb70608ff

comment:2 Changed 5 years ago by m-kiewitz

Owner: set to m-kiewitz
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.